Migrate GUI colors test to original CSS color format #114475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
Some changes occurred in HTML/CSS/JS. cc @GuillaumeGomez, @Folyd, @jsha |
GuillaumeGomez
force-pushed
the
migrate-gui-test-color-27
branch
from
1434250
to
85ed2fe
Compare
GuillaumeGomez
commented
Aug 4, 2023
| @@ -68,7 +68,7 @@ | |||
| --test-arrow-color: #f5f5f5; | |||
| --test-arrow-background-color: rgba(78, 139, 202, 0.2); | |||
| --test-arrow-hover-color: #f5f5f5; | |||
| --test-arrow-hover-background-color: #4e8bca; | |||
| --test-arrow-hover-background-color: rgb(78, 139, 202); | |||
There was a problem hiding this comment.
I changed the color scheme in this file and in dark.css to make it closer to --test-arrow-background-color so it's more obvious they're linked.
There was a problem hiding this comment.
I've confirmed that there are the same color. Just written differently.
|
@bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 5, 2023
…mpiler-errors Rollup of 5 pull requests Successful merges: - rust-lang#114287 (update overflow handling in the new trait solver) - rust-lang#114475 (Migrate GUI colors test to original CSS color format) - rust-lang#114482 (Fix ui-fulldeps missing the `internal_features` lint on stage 0) - rust-lang#114490 (Fix a typo in the error reporting for sealed traits.) - rust-lang#114491 (Rename issue rust-lang#114423 test files to include context) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #111459.
r? @notriddle