Change raster warning only if not explicitly supplied

[samuel-marsh]

Hi Seurat Team,

This is small change to clean up console output. Currently plots based on SingleExIPlot or SingleDimPlot issue a raster warning whenever the raster parameter is not FALSE and the number of points is over 100K. However, because of this it also continuously prints the message even when user explicitly sets the parameter to be TRUE. This can clutter output especially if return lots of plots in loop for something the user has explicitly set. This was mentioned previously in #7745. While I know that you can suppress such warnings many users may not.

This PR simply changes the !isFALSE(raster) to is.null(raster) since NULL is the default setting. Therefore it will only print warning when setting is not explicitly provided by the user.

This may have been specific design decision to warn every time plot is rasterized but seems unnecessary if user is supplying parameter. If it is specific design decision then feel free to ignore and close this PR.

Thanks as always,
Sam

[saketkc]

Thank you @samuel-marsh! I have implemented the change in 643a57d. Since we were about to release 4.4.0, we decided to do this internally rather then merging your PR. Thank you for your PR!

[samuel-marsh]

Hi @saketkc, Sounds good, thanks!!

[samuel-marsh]

Hi @saketkc,

REOPENING to ensure this is seen but feel free to close after that

I just wanted to let you know for when you propagate changes to the V5 branch (or potentially hotfix the 4.4.0 branch) there is one error in the raster changes in the 4.4.0 branch. It was actually plot I hadn't caught (SingleCorPlot).

The exclamation point before the is.null needs to be removed.

seurat/R/visualization.R

Line 7845 in 57564e2

if ((nrow(x = data) > 1e5) & !is.null(x = raster)){

Right now it will warn when explicitly TRUE or FALSE.

Best,
Sam

[saketkc]

Thanks Sam! I missed it too. We might release a hotfix and propogate to V5 (the latest V5 is synced up with V4.4.0)

[samuel-marsh]

Sounds good! I'll close this. Thanks again!