Highlight fix #7914
Merged
Highlight fix #7914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fyi: Appears the CI check error is due to BPCells install issue. |
|
Thanks Sam! Looks great! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @Gesmira & Seurat Team,
This is PR addresses two issues:
First, addressing #7891. I have added raster parameter to SetHighlight, and a check to change the pt.size returned if TRUE.
I have also made the fix mentioned in comments for PR #7842 which causes raster warning to accidentally be always displayed regardless of whether TRUE/FALSE is supplied.
Thanks again!
Best,
Sam