tests: bypass the proxy if testing timeouts #2349
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an explicit proxy is configured in the environment, the timeout tests will actually go through it, and then the test results will depend on the proxy's performance, which can vary. Testing this is very simple: ``` export http_proxy="http://127.0.0.1:1234" cargo test timeouts ``` We're hitting this issue in the Ubuntu CI. Further investigations after 892569e seemed to point that **sometimes**, the proxy would be too slow (particularly on non amd64 architectures), leading to the tests to actually timeout and pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an explicit proxy is configured in the environment, the timeout tests will actually go through it, and then the test results will depend on the proxy's performance, which can vary.
Testing this is very simple:
We're hitting this issue in the Ubuntu CI. Further investigations after 892569e seemed to point that sometimes, the proxy would be too slow (particularly on non amd64 architectures), leading to the tests to actually timeout and pass.