Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: bypass the proxy when testing timeouts #2349

Closed
wants to merge 1 commit into from
Closed

tests: bypass the proxy when testing timeouts #2349

wants to merge 1 commit into from

Commits on Jul 10, 2024

  1. tests: bypass the proxy if testing timeouts 

    If an explicit proxy is configured in the environment, the timeout tests
will actually go through it, and then the test results will depend on
the proxy's performance, which can vary.

Testing this is very simple:
```
export http_proxy="http://127.0.0.1:1234"
cargo test timeouts
```

We're hitting this issue in the Ubuntu CI. Further investigations
after 892569e seemed to point that
**sometimes**, the proxy would be too slow (particularly on non amd64
architectures), leading to the tests to actually timeout and pass.
    @Hyask
    Hyask committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    22e233e View commit details
    Browse the repository at this point in the history