Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v1 API endpoints do not work through HTTP if gRPC TLS is enabled #1267

Closed
bobcallaway opened this issue Jul 9, 2023 · 0 comments · Fixed by #1268
Closed

v1 API endpoints do not work through HTTP if gRPC TLS is enabled #1267

bobcallaway opened this issue Jul 9, 2023 · 0 comments · Fixed by #1268
Labels
bug Something isn't working

Comments

@bobcallaway
Copy link
Member

Description

fulcio/cmd/app/http.go

Line 76 in 3815318

if err := legacy_gw.RegisterCAHandlerFromEndpoint(ctx, mux, endpoint, opts); err != nil {
shouldn't reuse opts but always use insecure.Credentials() because we're connecting over a unix domain socket which doesn't have TLS

Version

v1.3.3
@bobcallaway bobcallaway added the bug Something isn't working label Jul 9, 2023
bobcallaway added a commit to bobcallaway/fulcio that referenced this issue Jul 9, 2023
@bobcallaway
always use non-TLS credentials to connect over unix domain socket
2dea6a9 
Fixes: sigstore#1267

Signed-off-by: Bob Callaway <[email protected]>
@bobcallaway bobcallaway mentioned this issue Jul 9, 2023
Merged
bobcallaway added a commit that referenced this issue Jul 10, 2023
@bobcallaway
always use non-TLS credentials to connect over unix domain socket (#1268
dcfd044 
)

Fixes: #1267

Signed-off-by: Bob Callaway <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

always use non-TLS credentials to connect over unix domain socket bobcallaway/fulcio
1 participant
@bobcallaway