Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

always use non-TLS credentials to connect over unix domain socket #1268

Merged
merged 1 commit into from
Jul 10, 2023

Conversation

bobcallaway
Copy link
Member

Fixes: #1267

Summary

Release Note

Documentation

@codecov
Copy link

codecov bot commented Jul 9, 2023

Codecov Report

Merging #1268 (2dea6a9) into main (3815318) will increase coverage by 1.70%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main    #1268      +/-   ##
==========================================
+ Coverage   55.86%   57.56%   +1.70%     
==========================================
  Files          50       50              
  Lines        2991     2993       +2     
==========================================
+ Hits         1671     1723      +52     
+ Misses       1167     1117      -50     
  Partials      153      153              
Impacted Files Coverage Δ
cmd/app/http.go 60.52% <66.66%> (+9.17%) ⬆️

... and 1 file with indirect coverage changes

@bobcallaway bobcallaway merged commit dcfd044 into sigstore:main Jul 10, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v1 API endpoints do not work through HTTP if gRPC TLS is enabled
3 participants