Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tutorial italian translation - Chapter 3 #865

Closed
wants to merge 2 commits into from
Closed

tutorial italian translation - Chapter 3 #865

wants to merge 2 commits into from

Conversation

marco-giordano
Copy link
Contributor

Italian translation of tutorial chapter 3

added chapter 3 and a modification on Welcome page
@samaaron
Copy link
Collaborator

samaaron commented Dec 8, 2015

This is looking great. When you've finished with the translation and would like it merged, could you possibly rebase the pull request so that it only contains modifications to the translation files (rather than merges).

Thanks for your fantastic work! :-)

@marco-giordano marco-giordano changed the title Chapter 3 tutorial italian translation - Chapter 3 Dec 8, 2015
@petterreinholdtsen
Copy link
Contributor

You might find the patch from pull request #870 interesting too.

@samaaron
Copy link
Collaborator

Hi there,

is there any chance you could rebase these changes onto master so I can pull them in? :-)

@marco-giordano
Copy link
Contributor Author

Hi Sam, I'm sorry but we are being very busy in these times so I haven't been able to get things done. Can you help me on how I can do a rebase?

@petterreinholdtsen
Copy link
Contributor

I had a look at the rebase, and it is not going to be easy. I tested this:

  1. git clone https://github.com/marco-giordano/sonic-pi sonic-pi-italian-tutorial
  2. cd sonic-pi-italian-tutorial/
  3. git remote add upstream https://github.com/samaaron/sonic-pi.git
  4. git fetch upstream
  5. git checkout -b testrebase
  6. git pull --rebase upstream master

The result was a lot of conflicts, and I doubt this is a good way forward. These kind of problems would be avoided if the tutorial translations are maintained as PO files, for example the way I propose it in pull request #870.

I suspect a better approach is to cherry-pick the relevant patches from your master branch and apply it on top of the latest upstream master branch.

@petterreinholdtsen
Copy link
Contributor

As far as I can tell, only commit 2edc0f9 is missing in the upstream master branch.

@hzulla
Copy link
Collaborator

hzulla commented May 20, 2016

@marco-giordano

Thank you very much for this.

I'm currently moving the translation to Weblate, see #1184.

Weblate will make translating Sonic Pi a whole lot easier.

Your additions in this pull request will be imported. (The import is a semi-automated process and will require a proofreading afterwards, but your great work so far will not be lost!)

@samaaron - this pull request can be closed, Marco's content has been imported in my local work branch and will move to Weblate later.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants