Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature request] createFromStructuredData method #231

Closed
ambroisemaupate opened this issue Nov 23, 2023 · 0 comments · Fixed by #232
Closed

[Feature request] createFromStructuredData method #231

ambroisemaupate opened this issue Nov 23, 2023 · 0 comments · Fixed by #232

Comments

@ambroisemaupate
Copy link
Contributor

ambroisemaupate commented Nov 23, 2023 •
edited
Loading

Hello,

Is there any plan to construct OpeningHours object from https://schema.org/OpeningHoursSpecification ?
If not, will you accept pull-request ?

I need to store opening-hours data in database then I chose to store as a native OpeningHoursSpecification JSON object, but I need to parse it for my business logic.

Maybe you'll have better options.
ambroisemaupate added a commit to ambroisemaupate/opening-hours that referenced this issue Nov 23, 2023
@ambroisemaupate
feat: Added OpeningHoursSpecificationParser with its unit-test to a…
4b6bcab 
…dd `OpeningHours::createFromStructuredData` method.

Fixes spatie#231
@ambroisemaupate ambroisemaupate mentioned this issue Nov 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@ambroisemaupate