Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support OpeningHoursSpecification structured data for creating OpeningHours #232

Merged
merged 3 commits into from
Nov 25, 2023

Conversation

ambroisemaupate
Copy link
Contributor

  • Adds OpeningHoursSpecificationParser final class with its unit-test
  • Adds OpeningHours::createFromStructuredData method.

Fixes #231

@codecov-commenter
Copy link

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (8ef0d60) 99.52% compared to head (ab33c74) 97.71%.

❗ Current head ab33c74 differs from pull request most recent head aa8f3b9. Consider uploading reports for the commit aa8f3b9 to get more accurate results

Files Patch % Lines
src/OpeningHoursSpecificationParser.php 79.76% 17 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #232      +/-   ##
============================================
- Coverage     99.52%   97.71%   -1.81%     
- Complexity      355      388      +33     
============================================
  Files            25       26       +1     
  Lines           834      921      +87     
============================================
+ Hits            830      900      +70     
- Misses            4       21      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kylekatarnls kylekatarnls merged commit 580d0c2 into spatie:master Nov 25, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature request] createFromStructuredData method
3 participants