Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 — Fix confirmation for reporting as spam while deleting an archived mail #1022

Merged

Conversation

ldidry
Copy link
Contributor

@ldidry ldidry commented Oct 14, 2020

Currently, if you want to report archived mail(s) as spam while asking for deletion, the confirmation page is shown twice (only once if not reporting as spam). It appears like a bug to users.
This commit remove the confirmation when reporting as spam (there is still the confirmation for the deletion).

… mail

Currently, if you want to report archived mail(s) as spam while asking for
deletion, the confirmation page is shown twice (only once if not reporting as
spam). It appears like a bug to users. This commit remove the
confirmation when reporting as spam (there is still the confirmation for
the deletion).
@ldidry
Copy link
Contributor Author

ldidry commented Oct 14, 2020

Relative to #634 and #640

Copy link
Member

@ikedas ikedas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel it proper. I agree to add it to the next milestone, 6.2.60.

Copy link
Contributor

@dverdin dverdin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple and efficient. I agree!

@ikedas
Copy link
Member

ikedas commented Oct 15, 2020

🍺

@ikedas ikedas added the bug label Oct 16, 2020
@ikedas ikedas added this to the 6.2.60 milestone Oct 22, 2020
@ldidry
Copy link
Contributor Author

ldidry commented Nov 16, 2020

Since 6.2.58 has been released, shouldn’t it be merged?

@ikedas ikedas merged commit e993c6a into sympa-community:sympa-6.2 Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants