Introducing external js color picker plugin #369
Conversation
default/web_tt2/skinsedit.tt2
Outdated
| <div class="small-6 medium-3 columns" role="cell"> | ||
| <input type="text" class="colorPicker" id="error_color" name="error_color" | ||
| value="[% error_color %]" data-color="[% error_color %]" | ||
| disabled="dsabled" /> |
There was a problem hiding this comment.
Typo s/dsabled/disabled/ ?
|
I took a quick look at the commits and didn't found anything obvious beside the typo. |
| </p> | ||
| <div id="help.Colors" class="secondary callout" data-closable> | ||
| <p> | ||
| [%|loc%]Use the color editor in order to change defined colors. First select the color you want to change and pick a color,then apply it using the test button. The new color is not really installed but it is used only for your own session. When happy with the different colors you chosen, you may save them in a new static CSS.[%END%] |
There was a problem hiding this comment.
Missing space, s/color,then/color, then/
Typo, s/you chosen/you have chosen/
There was a problem hiding this comment.
As I took care not to change existing phrases, it would be corrected in translation catalog (see also description in #115).
There was a problem hiding this comment.
Sorry, what needs to be done here is unclear to me.
Shall it be corrected both here and in the translation catalog ? Or only in the translation catalog (po/sympa/sympa.pot) ?
There was a problem hiding this comment.
Indeed the pointer was unclear.
#115 (comment)
- On English page of translation site, add correct string as a "translation" of incorrect msgid.
Your change on the site above will be reflected to source distribution in the future release.
| </ol> | ||
| <div id="help.ColorChart" class="secondary callout" data-closable> | ||
| <p> | ||
| [%|loc%]Please note that these desciptions don't cover the exact usage of each color parameter, as it would be far too long to describe. What lies in this table should however give you a correct snapshot of what the color parameters are used for. For more details on rendering, feel free to try changing the colors in your session to see how well that works.[%END%] |
There was a problem hiding this comment.
s/desciptions/descriptions/
This PR will replace Sympa's home-made color picker with jQuery MiniColors licensed under MIT license.
This change may reduce traffic by javascript (a very little) and cost for maintenance.
And, it may close issue #334 (Sympa bundles part of code taken from other software package).