Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added CustomHttpResponseHeadersFilter #1235

Merged
merged 28 commits into from
Oct 19, 2022
Merged

Added CustomHttpResponseHeadersFilter #1235

merged 28 commits into from
Oct 19, 2022

Conversation

AdiWehrli
Copy link
Contributor

With this filter we can configurably define response headers to be added to each HTTP response.

tchiotludo
tchiotludo requested changes Oct 18, 2022
View reviewed changes
Copy link
Owner

@tchiotludo tchiotludo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost good

Please :

src/main/java/org/akhq/middlewares/CustomHttpResponseHeadersFilter.java Outdated Show resolved Hide resolved
@AdiWehrli
Copy link
Contributor Author

What exactly does this error message mean: Couldn't find any clusters on your configuration file, please ensure that the configuration file is loaded correctly?

@tchiotludo
Copy link
Owner

It's because your application-custom-http-response-headers.yml don't contain any valid Kafka cluster, just add a false one, I think it will work

@AdiWehrli
Copy link
Contributor Author

Finally all checks have passed :)

@AdiWehrli
Copy link
Contributor Author

I added another test for the situation if no custom HTTP response headers were configured.

@AdiWehrli
Copy link
Contributor Author

AdiWehrli commented Oct 19, 2022 •
edited
Loading

So, I will not change anything more at this moment.

@tchiotludo tchiotludo merged commit d0a5f19 into tchiotludo:dev Oct 19, 2022
@tchiotludo
Copy link
Owner

merged, thanks a lot 👍

@AdiWehrli
Copy link
Contributor Author

merged, thanks a lot 👍

Thanks to you. Now I hope, that this filter will be recognized and created on start of Micronaut.

@AdiWehrli
Copy link
Contributor Author

By the way: when do you plan to release the next version?

@tchiotludo
Copy link
Owner

It's available on dev version.
The release will be when this was done (upgrade to latest micronaut version)

@AdiWehrli
Copy link
Contributor Author

PS: I tested AKHQ now on our development server and the custom HTTP response headers implementation work like a charm.

@tchiotludo
Copy link
Owner

Still better to ask for PR instead on building on your own house 😺

12ushan added a commit to giffgaff/akhq that referenced this pull request Nov 22, 2022
@12ushan @moremagic
@tooptoop4 @smasala @AnStrelnikov @marcellorego @10xtechie @ThomasSanson @tchiotludo @rdrck47 @rogerioefonseca @thomas-chauvet @erikgb @neeraj-singh47 @sam0r040 @Argonus @ali-1995 @alexvaque @itscaro @AdiWehrli @lucapette @tristanexsquare @meeraj257 @GnanaJeyam @owidder @HailToDodongo @raph-af @raphael-afanyan @alozano3 @ebrard
Pull from upstream 0.23 (#11)
e0db9cb 
* fix(topicdata): handle unsupported DescribeLogDirs  for MSK Serverless (tchiotludo#1113)

close tchiotludo#1112

* chore(deps): upgrade aws-msk-iam-auth to 1.1.4 to avoid vulnerability (tchiotludo#1114)

https://github.com/aws/aws-msk-iam-auth/releases/tag/v1.1.4 shows several fixes for CVEs

* chore(docs): add tui to usage list (tchiotludo#1118)

* chore(docs): update alt text for tui (tchiotludo#1119)

* chore(docs): add tui logo to public assets (tchiotludo#1120)

* feat(topicdata): adding serializer for protobuf schema registry (tchiotludo#1117)

* feat(topicdata): allow integer/long to be serialized as float/double when using AVRO schema. (tchiotludo#1123)

close tchiotludo#1122

* feat(ui): add pagination size of topic list (tchiotludo#1109)

relate tchiotludo#1051

* feat(acsl): add  Pattern Type to ACLs Panel Information (tchiotludo#1125)

close tchiotludo#1115

* fix(docker): run upgrade in order to reduce CVEs (tchiotludo#1134)

libssl1.1
dpkg
libldap-common

close tchiotludo#1132

* feat(docker): add healthcheck (tchiotludo#1136)


Co-authored-by: Ludovic DEHON <[email protected]>

* fix(ui): handle consumer group with slash (tchiotludo#1143)

close tchiotludo#1101

* Revert "chore(readme): add redpanda sponsors"

This reverts commit ab9a444.

* fix(helm): adding namespace to kubectl port-forward Helm Chart NOTES (tchiotludo#1171)

Co-authored-by: rogerio <[email protected]>

* fix(helm): correct port for port-forward is 8080 (tchiotludo#1178)

Fix port displayed at the end of the helm release.

It displays `{{ .Values.service.port }}` which is `80` per default, it should be `8080`.

* feat(docker): change upstream image from openjdk to eclipse-temurin (tchiotludo#1179)


Signed-off-by: Erik Godding Boye <[email protected]>

* fix(core): close consumer when returning null after calculating offset for newest sort (tchiotludo#1069)

fix a memory leak 

Co-authored-by: Neeraj.singh <[email protected]>

* fix(ui): load, display and store settings on settings screen if no settings have been stored yet (tchiotludo#1161)

Co-authored-by: David Müller <[email protected]>

* feat(docs): update vuepress to last versions

* chore(docs): add Fresha to whos using (tchiotludo#1111)

* chore(version): update to 0.22.0

* fix(ui): showing protobuf schema in versions tab crash (tchiotludo#1189)

Fixes tchiotludo#1188

* feat(docs): helm example with basic auth and aws msk (tchiotludo#1192)


Co-authored-by: Ludovic DEHON <[email protected]>

* feat(helm): add networkpolicy (tchiotludo#1193)

Signed-off-by: Quan TRAN <[email protected]>

* feat(helm): add configuration for readiness & livenessProbe

* chore(deps) add missing scala dependent modules (tchiotludo#1223)

* feat(docs): add a Kestra banner

* fix(topicdata): protection against tombstone message and headers

close tchiotludo#1210

* feat(webserver): add custom headers configuration (tchiotludo#1235)


Co-authored-by: Ludovic DEHON <[email protected]>

* chore(docs): fix typo (tchiotludo#1240)

* chore(cicd): update slack channel

* fix(ui): decimals are not parsed correctl (tchiotludo#1246)

replaced 'json-bigint' parser with 'lossless-json', this replacement allows for pretty-printing the json data, but still keeping the original values especially for floating numbers and bigints.

fix tchiotludo#1006

* core(deps): Updated micronaut to latest version (tchiotludo#1247)

and fixes to tests to have a successful build

close tchiotludo#1215

* fix(ui): Disabled edit access topic configs when role has reader mode (tchiotludo#1237)

close tchiotludo#1219

* fix(ui): encode groupId to allow '&' as part of the name of a consumer group (tchiotludo#1184)


relate to tchiotludo#1143

* feat(ui): faster topic-data search & sorting (tchiotludo#1209)


Co-authored-by: Max Bebök <[email protected]>

* feat(topicdata): added fix for incorrect datatype and missing fields in the json while producing to topic (tchiotludo#1233)

* feat(ui): Use `set INLINE_RUNTIME_CHUNK=false&& ` in react build. (tchiotludo#1238)

See also https://drag13.io/posts/react-inline-runtimer-chunk/index.html. This is to make _Content-Security-Policy_ work when `unsafe-inline` is not set.

Co-authored-by: Ludovic DEHON <[email protected]>

* fix(node):  fix nullpointer when trying to view cluster information in MSK Serverless (tchiotludo#1227)

close tchiotludo#1226

Co-authored-by: Ludovic DEHON <[email protected]>

* chore(deps): update all java deps

* feat(ui): optimze svgs with https://jakearchibald.github.io/svgomg/ (tchiotludo#1252)

In preparation for a React upgrade, see tchiotludo#1243

* feat(topicdata): support duplicate header keys (tchiotludo#1258)

close tchiotludo#1257 

Co-authored-by: rafanyan <[email protected]>

* chore(deps): update codeql actions to supported version (tchiotludo#1253)

See
https://github.blog/changelog/2022-04-27-code-scanning-deprecation-of-codeql-action-v1/
for context

* chore(version): update to 0.23.0

* feat(ui): update node to the latest lts version (tchiotludo#1251)

* Update node to the latest LTS version
* Replace node-sass with sass
* Also use the correct version of react-test-renderer.
* Update react scripts so we don't use insecure hashing functions
* Do not check eslint for production build

See tchiotludo#1243 for more information.

* fix(topicdata): fix null key and value (tchiotludo#1261)

Co-authored-by: alozano3 <[email protected]>

* feat(ui): fix eslint warnings (tchiotludo#1254)


Co-authored-by: Ludovic DEHON <[email protected]>

* fix(topci): create topics with configuration in one call (tchiotludo#1273)

close tchiotludo#1272

Signed-off-by: Erik Godding Boye <[email protected]>
Signed-off-by: Quan TRAN <[email protected]>
Co-authored-by: Mitsuaki Ito <[email protected]>
Co-authored-by: tooptoop4 <[email protected]>
Co-authored-by: Steven Masala <[email protected]>
Co-authored-by: Steven Masala <[email protected]>
Co-authored-by: Andrei Strelnikov <[email protected]>
Co-authored-by: Marcello <[email protected]>
Co-authored-by: 10xtechie <[email protected]>
Co-authored-by: ThomasSanson <[email protected]>
Co-authored-by: Ludovic DEHON <[email protected]>
Co-authored-by: Rodrigo Rodriguez Ramos <[email protected]>
Co-authored-by: Rogério Fonseca <[email protected]>
Co-authored-by: rogerio <[email protected]>
Co-authored-by: Thomas <[email protected]>
Co-authored-by: Erik Godding Boye <[email protected]>
Co-authored-by: neeraj-singh47 <[email protected]>
Co-authored-by: Neeraj.singh <[email protected]>
Co-authored-by: sam0r040 <[email protected]>
Co-authored-by: David Müller <[email protected]>
Co-authored-by: Piotr Rybarczyk <[email protected]>
Co-authored-by: Ali Akhtari <[email protected]>
Co-authored-by: Alex Vaque <[email protected]>
Co-authored-by: Quan TRAN <[email protected]>
Co-authored-by: Adi Wehrli <[email protected]>
Co-authored-by: lucapette <[email protected]>
Co-authored-by: tristanessquare <[email protected]>
Co-authored-by: meeraj257 <[email protected]>
Co-authored-by: Gnana_Jeyam <[email protected]>
Co-authored-by: owidder <[email protected]>
Co-authored-by: Stuff is on GitLab <[email protected]>
Co-authored-by: Max Bebök <[email protected]>
Co-authored-by: Raphael <[email protected]>
Co-authored-by: rafanyan <[email protected]>
Co-authored-by: Albert <[email protected]>
Co-authored-by: alozano3 <[email protected]>
Co-authored-by: Emmanuel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tchiotludo tchiotludo Awaiting requested review from tchiotludo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AdiWehrli @tchiotludo