-
-
Notifications
You must be signed in to change notification settings - Fork 647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update node to the latest LTS version #1251
Conversation
yes it makes sense it fails :) so we can't do a separate pr for the node-sass. If we upgrade node, we have to upgrade the lib. I will do that now and see if that makes it green) |
Progress with the node sass to sass replacement and the correct version of react test rendered. But apparently not enough. The error looks funky. I'll investigate |
So unfortunately it seems to me we're going to end up in a very similar place as the other pull requests (as they're all connected in the end). Updating react scripts will fix the current error (see https://stackoverflow.com/questions/69692842/error-message-error0308010cdigital-envelope-routinesunsupported for more information) But the build still fails because of the svg images. I opened a separate pull request for that #1252 so when we merge that, I will rebase this branch and we should see the eslint errors only. We can decide what to do when we get there. Unfortunately the fact that the JS ecosystem moves really fast makes fixing this build a little tricky... |
i know it will be tricky one, the svg is merged, you can rebase it if you want |
Also use the correct version of react-test-renderer. See tchiotludo#1243 for more information.
919aeb3
to
0e3b4fb
Compare
I just rebased and pushed it :) Yes it'll be a little tricky but it should improve the situation quite a bit. I'm still quite optimistic we'll get it done 💪. Let's see what's the next build error now 🙃 |
so yes, eslint errors it is. I see two options:
Not sure what I'd do (I see arguments for both) but surely we should go for whatever you're more comfortable with |
maybe make a little test locally to see if the interface is working for now ? |
Good point! Let me check. I'll report back what I find |
12a27c1
to
d94b452
Compare
ah! Almost... I think there's warnings because of the sass upgrade as well. Let me investigate those! |
d94b452
to
9baa37b
Compare
So I was both right and wrong about sass. Yes there are warnings but those are not the problem. The problem is that react scripts when Now that it's green, let me recap what I did:
I wish we could do these in separate steps but I think it would end up being more work than this. If we merge this, I'll immediately open a draft PR where I remove the Of course, once again, we should do whatever you're more comfortable with. I understand merging this may be a bit uncomfortable. |
Thanks for ✔️ ;) The better IMO, will be to created another PR using this branch as base ? What do you think? |
You mean so that I can start working on the eslint warnings? (Sorry I'm not sure I understand the question). |
Yes If you want and have the time! Do you got it? Does it make sense? |
yes! I'll see what I can do with the eslint warnings :) |
* fix(topicdata): handle unsupported DescribeLogDirs for MSK Serverless (tchiotludo#1113) close tchiotludo#1112 * chore(deps): upgrade aws-msk-iam-auth to 1.1.4 to avoid vulnerability (tchiotludo#1114) https://github.com/aws/aws-msk-iam-auth/releases/tag/v1.1.4 shows several fixes for CVEs * chore(docs): add tui to usage list (tchiotludo#1118) * chore(docs): update alt text for tui (tchiotludo#1119) * chore(docs): add tui logo to public assets (tchiotludo#1120) * feat(topicdata): adding serializer for protobuf schema registry (tchiotludo#1117) * feat(topicdata): allow integer/long to be serialized as float/double when using AVRO schema. (tchiotludo#1123) close tchiotludo#1122 * feat(ui): add pagination size of topic list (tchiotludo#1109) relate tchiotludo#1051 * feat(acsl): add Pattern Type to ACLs Panel Information (tchiotludo#1125) close tchiotludo#1115 * fix(docker): run upgrade in order to reduce CVEs (tchiotludo#1134) libssl1.1 dpkg libldap-common close tchiotludo#1132 * feat(docker): add healthcheck (tchiotludo#1136) Co-authored-by: Ludovic DEHON <[email protected]> * fix(ui): handle consumer group with slash (tchiotludo#1143) close tchiotludo#1101 * Revert "chore(readme): add redpanda sponsors" This reverts commit ab9a444. * fix(helm): adding namespace to kubectl port-forward Helm Chart NOTES (tchiotludo#1171) Co-authored-by: rogerio <[email protected]> * fix(helm): correct port for port-forward is 8080 (tchiotludo#1178) Fix port displayed at the end of the helm release. It displays `{{ .Values.service.port }}` which is `80` per default, it should be `8080`. * feat(docker): change upstream image from openjdk to eclipse-temurin (tchiotludo#1179) Signed-off-by: Erik Godding Boye <[email protected]> * fix(core): close consumer when returning null after calculating offset for newest sort (tchiotludo#1069) fix a memory leak Co-authored-by: Neeraj.singh <[email protected]> * fix(ui): load, display and store settings on settings screen if no settings have been stored yet (tchiotludo#1161) Co-authored-by: David Müller <[email protected]> * feat(docs): update vuepress to last versions * chore(docs): add Fresha to whos using (tchiotludo#1111) * chore(version): update to 0.22.0 * fix(ui): showing protobuf schema in versions tab crash (tchiotludo#1189) Fixes tchiotludo#1188 * feat(docs): helm example with basic auth and aws msk (tchiotludo#1192) Co-authored-by: Ludovic DEHON <[email protected]> * feat(helm): add networkpolicy (tchiotludo#1193) Signed-off-by: Quan TRAN <[email protected]> * feat(helm): add configuration for readiness & livenessProbe * chore(deps) add missing scala dependent modules (tchiotludo#1223) * feat(docs): add a Kestra banner * fix(topicdata): protection against tombstone message and headers close tchiotludo#1210 * feat(webserver): add custom headers configuration (tchiotludo#1235) Co-authored-by: Ludovic DEHON <[email protected]> * chore(docs): fix typo (tchiotludo#1240) * chore(cicd): update slack channel * fix(ui): decimals are not parsed correctl (tchiotludo#1246) replaced 'json-bigint' parser with 'lossless-json', this replacement allows for pretty-printing the json data, but still keeping the original values especially for floating numbers and bigints. fix tchiotludo#1006 * core(deps): Updated micronaut to latest version (tchiotludo#1247) and fixes to tests to have a successful build close tchiotludo#1215 * fix(ui): Disabled edit access topic configs when role has reader mode (tchiotludo#1237) close tchiotludo#1219 * fix(ui): encode groupId to allow '&' as part of the name of a consumer group (tchiotludo#1184) relate to tchiotludo#1143 * feat(ui): faster topic-data search & sorting (tchiotludo#1209) Co-authored-by: Max Bebök <[email protected]> * feat(topicdata): added fix for incorrect datatype and missing fields in the json while producing to topic (tchiotludo#1233) * feat(ui): Use `set INLINE_RUNTIME_CHUNK=false&& ` in react build. (tchiotludo#1238) See also https://drag13.io/posts/react-inline-runtimer-chunk/index.html. This is to make _Content-Security-Policy_ work when `unsafe-inline` is not set. Co-authored-by: Ludovic DEHON <[email protected]> * fix(node): fix nullpointer when trying to view cluster information in MSK Serverless (tchiotludo#1227) close tchiotludo#1226 Co-authored-by: Ludovic DEHON <[email protected]> * chore(deps): update all java deps * feat(ui): optimze svgs with https://jakearchibald.github.io/svgomg/ (tchiotludo#1252) In preparation for a React upgrade, see tchiotludo#1243 * feat(topicdata): support duplicate header keys (tchiotludo#1258) close tchiotludo#1257 Co-authored-by: rafanyan <[email protected]> * chore(deps): update codeql actions to supported version (tchiotludo#1253) See https://github.blog/changelog/2022-04-27-code-scanning-deprecation-of-codeql-action-v1/ for context * chore(version): update to 0.23.0 * feat(ui): update node to the latest lts version (tchiotludo#1251) * Update node to the latest LTS version * Replace node-sass with sass * Also use the correct version of react-test-renderer. * Update react scripts so we don't use insecure hashing functions * Do not check eslint for production build See tchiotludo#1243 for more information. * fix(topicdata): fix null key and value (tchiotludo#1261) Co-authored-by: alozano3 <[email protected]> * feat(ui): fix eslint warnings (tchiotludo#1254) Co-authored-by: Ludovic DEHON <[email protected]> * fix(topci): create topics with configuration in one call (tchiotludo#1273) close tchiotludo#1272 Signed-off-by: Erik Godding Boye <[email protected]> Signed-off-by: Quan TRAN <[email protected]> Co-authored-by: Mitsuaki Ito <[email protected]> Co-authored-by: tooptoop4 <[email protected]> Co-authored-by: Steven Masala <[email protected]> Co-authored-by: Steven Masala <[email protected]> Co-authored-by: Andrei Strelnikov <[email protected]> Co-authored-by: Marcello <[email protected]> Co-authored-by: 10xtechie <[email protected]> Co-authored-by: ThomasSanson <[email protected]> Co-authored-by: Ludovic DEHON <[email protected]> Co-authored-by: Rodrigo Rodriguez Ramos <[email protected]> Co-authored-by: Rogério Fonseca <[email protected]> Co-authored-by: rogerio <[email protected]> Co-authored-by: Thomas <[email protected]> Co-authored-by: Erik Godding Boye <[email protected]> Co-authored-by: neeraj-singh47 <[email protected]> Co-authored-by: Neeraj.singh <[email protected]> Co-authored-by: sam0r040 <[email protected]> Co-authored-by: David Müller <[email protected]> Co-authored-by: Piotr Rybarczyk <[email protected]> Co-authored-by: Ali Akhtari <[email protected]> Co-authored-by: Alex Vaque <[email protected]> Co-authored-by: Quan TRAN <[email protected]> Co-authored-by: Adi Wehrli <[email protected]> Co-authored-by: lucapette <[email protected]> Co-authored-by: tristanessquare <[email protected]> Co-authored-by: meeraj257 <[email protected]> Co-authored-by: Gnana_Jeyam <[email protected]> Co-authored-by: owidder <[email protected]> Co-authored-by: Stuff is on GitLab <[email protected]> Co-authored-by: Max Bebök <[email protected]> Co-authored-by: Raphael <[email protected]> Co-authored-by: rafanyan <[email protected]> Co-authored-by: Albert <[email protected]> Co-authored-by: alozano3 <[email protected]> Co-authored-by: Emmanuel <[email protected]>
* Update node to the latest LTS version * Replace node-sass with sass * Also use the correct version of react-test-renderer. * Update react scripts so we don't use insecure hashing functions * Do not check eslint for production build See #1243 for more information.
as per discussion in #1243
Unfortunately I can't test this locally so I opened a pull-request before being sure it passes CI (not my "style")