Create new test suite #335
Labels
type: quality
Improves quality of the app or the user experience.
Milestone
Comments
|
Well, the old test suite "tests" code that no longer exists. I could create new one during ongoing modernization. |
jiri-janousek
added
the
type: quality
jiri-janousek
added a commit
that referenced
this issue
May 6, 2017
No longer functional. Issue: #335 Signed-off-by: Jiří Janoušek <[email protected]>
|
Old tests have been removed. |
jiri-janousek
added a commit
that referenced
this issue
May 16, 2017
* build/run-nuvolaplayer3-tests * WebAppTest is the first test * Issue: #335 Signed-off-by: Jiří Janoušek <[email protected]>
|
Nuvola has the first test on a new test suite. It is built by default and can be executed as build/run-nuvolaplayer3-tests with a proper LD_LIBRARY_PATH. More tests will come as the modernization proceeds further. |
jiri-janousek
added a commit
that referenced
this issue
May 27, 2017
New Features:
* Tray icon feature can now use AppIndicator library instead of
obsolete X11 tray icons. Although app indicators are mostly known
from Ubuntu's Unity desktop, they also work in elementaryOS and
GNOME Shell (with
[AppIndicator extension](https://extensions.gnome.org/extension/615/appindicator-support))
and provide superior user experience. Issue: #45
* Users can easily clear cookies, cache and temporary files, IndexedDB
and WebSQL databases and local storage from the Preferences dialog
→ tab Website Data. Issue: #331
Enhancements:
* Versioning scheme was changed to be more compact, e.g. 4.4.1 instead
of 3.1.4-1.gabcd. Nuvola 4.0 was re-targeted as Nuvola 5.0.
* Nuvola can do its own user agent quirks (i.e. to disguise itself as
a different web browser) in order to work around web pages that
doesn't work with the WebKit's user agent string.
Issue: #336
* Flatpak builds use the latest stable WebKitGTK+ 2.16.3 bringing
fixes for three security vulnerabilities as well as several crashes
and rendering issues.
Web App Scripts:
* Google Play Music script uses own user agent quirks to work around
the malfunctioning Google sign-in web page.
Issue: #336
Bug fixes:
* The build script now raises error if it is ran with Python < 3.4.
* Fixed a bug when the menus of tray icons and dock items were not
updated.
* Nuvola now aborts when required data files are not found (e.g. in
incomplete installation) rather they running with errors in the
background.
* Obsolete test suite has been removed. A new one will be created
during ongoing modernization. Issue: #335
* Broken -L/--log-file options were removed.
Issue: #338
* Various fixes of HTTP Remote Control feature.
Under the Hood:
* Nuvola's filesystem namespace was changed from `nuvolaplayer3` to
`nuvolaruntime`. The data dir is installed at
PREFIX/share/nuvolaruntime, libraries were renamed to
`libnuvolaruntime-*.so` and binaries to `nuvola(ctl)`.
Users' configuration, data and cache is migrated automatically.
* Nuvola's git repository was moved to
https://github.com/tiliado/nuvolaruntime.
* WebKitGTK+ >= 2.16.0 is required as all new API is now used
unconditionally to make maintenance easier.
* Added optional dependency on appindicator3-0.1 >= 0.4.
Use `./waf configure --noappindicator` to disable
this dependency and related functionality (Tray icon feature).
* Nuvola no longer bundles Engine.io-client JavaScript library
but expects version 3.1.0 of it located at the
JSDIR/engine.io-client/engine.io.js (JSDIR is DATADIR/javascript
unless changed with --jsdir).
Issue: #341
* Nuvola no longer supports web app scripts without a desktop file.
* Test suite was reintroduced (build/run-nuvolaruntime-tests).
Issue: #335
* A lot of refactoring and removal of obsolete code and other
improvements.
Signed-off-by: Jiří Janoušek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The first attempt of a test suite was abandoned years ago and "tests" code that no longer exists. Let's create new one.
Original report:
i tried to run the test suite via rpm spec file:
https://martinkg.fedorapeople.org/Packages/nuvolaplayer/nuvolaplayer.spec
made some modifications
but this fails with:
if i run make all in the source folder i get this:
the tests were not modified in past 3 years, so they might not be in good shape... will you change that?
The text was updated successfully, but these errors were encountered: