-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Unity AppIndicator #45
Comments
AppIndicator integration is currently unmaintained. - Issue: #201 - Issue: #45 Signed-off-by: Jiří Janoušek <[email protected]>
AppIndicator integration is currently unmaintained. - Issue: #201 - Issue: #45 Signed-off-by: Jiří Janoušek <[email protected]>
This is a bug fix release addressing following issues: * Configuration option --with-appindicator was removed as AppIndicator integration is currently unmaintained. Issues: #201 and #45 * Web app integration template was moved to [its own repository](https://github.com/tiliado/nuvola-app-template) to keep it up-to-date independently on Nuvola Player releases. Developer documentation was updated accordingly. * The `nuvolaplayer3 --help` screen now lists also the `-a/--app-id` argument used to launch a particular service. Issue: #147 * All pop-up windows now can pop up a new window, which is required by the SoundCloud's log-in-via-Google feature, for instance. Issue: tiliado/nuvola-app-soundcloud#3 Signed-off-by: Jiří Janoušek <[email protected]>
This feature would be great, it is missing very much for me :(. |
Hello @regisz. Would you like to sponsor development of this feature then? |
ok, maybe :). How much bounty is required for this feature? |
Hello @regisz. There used to be AppIndicator support in Nuvola Player but it was disabled because of some issues and the code became unmaintained and broken (#201). It might take an hour (€15) to get the old code work again and another hour to address the issues (€15) providing there are no obstacles. The process is a bit complicated by the fact that I don't use Ubuntu on my development machine, so all development will have to occur in Ubuntu in VirtualBox. Hello @susnux. You were interested in libappindicator support in #201. Would you like to join @regisz to fund a comeback of this feature? |
❤️ One Nuvola Patron is interested in this feature. As a result, the ticket has been moved from the "postponed" queue to the "ready" queue and the "patron" label has been attached. |
cool, I'm waiting this feature :)!
2016-11-26 22:04 GMT+01:00 Jiří Janoušek <[email protected]>:
… In progress: https://github.com/tiliado/nuvolaplayer/tree/appindicator
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#45 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AE6FWuGasrmNRguQE1hBYa9Ks_3uOpP4ks5rCJ7ygaJpZM4DFILv>
.
|
Hello @regisz. I apologize for not finishing this feature yet. It turned out to have been more difficult that I had expected. The top priority for now is to release stable flatpak builds of Nuvola 3.1. Thrn I might get back to this issue. |
Hello @regisz. With Nuvola 3.1.3 flatpaks in the wild, I can finally return to this issue. |
Rebased on master: https://github.com/tiliado/nuvolaplayer/tree/appindicator2 |
@fenryxo thx :) |
No, this branch has not been merged to master as it is still incomplete. It should be included in Nuvola 3.1.4 later this month. |
Remaining issues:
|
Issue: #45 Signed-off-by: Jiří Janoušek <[email protected]>
Also fixes icon of appindicator. Issue: #45 Signed-off-by: Jiří Janoušek <[email protected]>
Final tasks:
|
Pushed to the stable repo. Run Instructions & Screenshots: |
New Features: * Tray icon feature can now use AppIndicator library instead of obsolete X11 tray icons. Although app indicators are mostly known from Ubuntu's Unity desktop, they also work in elementaryOS and GNOME Shell (with [AppIndicator extension](https://extensions.gnome.org/extension/615/appindicator-support)) and provide superior user experience. Issue: #45 * Users can easily clear cookies, cache and temporary files, IndexedDB and WebSQL databases and local storage from the Preferences dialog → tab Website Data. Issue: #331 Enhancements: * Versioning scheme was changed to be more compact, e.g. 4.4.1 instead of 3.1.4-1.gabcd. Nuvola 4.0 was re-targeted as Nuvola 5.0. * Nuvola can do its own user agent quirks (i.e. to disguise itself as a different web browser) in order to work around web pages that doesn't work with the WebKit's user agent string. Issue: #336 * Flatpak builds use the latest stable WebKitGTK+ 2.16.3 bringing fixes for three security vulnerabilities as well as several crashes and rendering issues. Web App Scripts: * Google Play Music script uses own user agent quirks to work around the malfunctioning Google sign-in web page. Issue: #336 Bug fixes: * The build script now raises error if it is ran with Python < 3.4. * Fixed a bug when the menus of tray icons and dock items were not updated. * Nuvola now aborts when required data files are not found (e.g. in incomplete installation) rather they running with errors in the background. * Obsolete test suite has been removed. A new one will be created during ongoing modernization. Issue: #335 * Broken -L/--log-file options were removed. Issue: #338 * Various fixes of HTTP Remote Control feature. Under the Hood: * Nuvola's filesystem namespace was changed from `nuvolaplayer3` to `nuvolaruntime`. The data dir is installed at PREFIX/share/nuvolaruntime, libraries were renamed to `libnuvolaruntime-*.so` and binaries to `nuvola(ctl)`. Users' configuration, data and cache is migrated automatically. * Nuvola's git repository was moved to https://github.com/tiliado/nuvolaruntime. * WebKitGTK+ >= 2.16.0 is required as all new API is now used unconditionally to make maintenance easier. * Added optional dependency on appindicator3-0.1 >= 0.4. Use `./waf configure --noappindicator` to disable this dependency and related functionality (Tray icon feature). * Nuvola no longer bundles Engine.io-client JavaScript library but expects version 3.1.0 of it located at the JSDIR/engine.io-client/engine.io.js (JSDIR is DATADIR/javascript unless changed with --jsdir). Issue: #341 * Nuvola no longer supports web app scripts without a desktop file. * Test suite was reintroduced (build/run-nuvolaruntime-tests). Issue: #335 * A lot of refactoring and removal of obsolete code and other improvements. Signed-off-by: Jiří Janoušek <[email protected]>
From Launchpad bug #1130245 by Maikel:
Unity doesn't support sys tray icons, add support for AppIndicator instead.
❤️ One Nuvola Patron is interested in this feature. Internal info: (1).
The text was updated successfully, but these errors were encountered: