[ext] build separate packages for Firefox and Chrome (manifest v3) #1982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GresilleSiffle
approved these changes
Jun 13, 2024
5 tasks
NatNgs
pushed a commit
that referenced
this pull request
Jul 4, 2024
…1982) * [ext] build separate packages for Firefox (manifest v2) and Chrome (manifest v3) * bump version * lint fix * update e2e workflow to use extension with manifest v3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Chrome is deprecating Manifest v2.
https://blog.chromium.org/2024/05/manifest-v2-phase-out-begins.html
2 distinct builds will be released:
The GitHub workflows are updated to write both versions in the artifact, and upload them to Discord.
The e2e tests workflow is also updated to use the Manifest v3 when testing the extension in Chrome.
Checklist