-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ginkgo: light: fix typo #2
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mg712702
pushed a commit
that referenced
this pull request
Oct 18, 2020
Fix C2 brightness curve to reflect typical display peak brightness. Since both C2 and F2 devices have linear brightness curves, this CL also simplifies the brightness setting by omitting unnecessary LUT entries and moving the brightness curves to a common overlay. Bug: 136293167 Test: Manually tested F2 and C2 by shining a flashlight at the ALS and doing the following: 1) Read mLastObservedLux and mScreenAutoBrightness (adb shell dumpsys display) 2) Find out the target nits value from config_autoBrightnessLevels and config_autoBrightnessDisplayValuesNits, using mLastObservedLux 3) Calculate the predicted display nits assuming a linear mapping from [1, 255] to [2 nits, 450 nits], for the read mScreenAutoBrightness 4) Compare results from #3 and #2 5) Repeat for F2 and C2, for 3 lux points Change-Id: Iaa221cf9f5169a0fbd08abec492518c58c134e38 Signed-off-by: Mrinal Ghosh <[email protected]>
mg712702
pushed a commit
that referenced
this pull request
Oct 18, 2020
Fix C2 brightness curve to reflect typical display peak brightness. Since both C2 and F2 devices have linear brightness curves, this CL also simplifies the brightness setting by omitting unnecessary LUT entries and moving the brightness curves to a common overlay. Bug: 136293167 Test: Manually tested F2 and C2 by shining a flashlight at the ALS and doing the following: 1) Read mLastObservedLux and mScreenAutoBrightness (adb shell dumpsys display) 2) Find out the target nits value from config_autoBrightnessLevels and config_autoBrightnessDisplayValuesNits, using mLastObservedLux 3) Calculate the predicted display nits assuming a linear mapping from [1, 255] to [2 nits, 450 nits], for the read mScreenAutoBrightness 4) Compare results from #3 and #2 5) Repeat for F2 and C2, for 3 lux points Change-Id: Iaa221cf9f5169a0fbd08abec492518c58c134e38 Signed-off-by: Mrinal Ghosh <[email protected]>
mg712702
pushed a commit
that referenced
this pull request
Mar 8, 2021
* crashes HWC due to a double-free in libdpps: 02-07 18:18:27.793 2066 2066 F DEBUG : *** *** *** *** *** *** *** *** *** *** *** *** *** *** *** *** 02-07 18:18:27.793 2066 2066 F DEBUG : ArrowOS Version: 'Arrow-v11.0-ginkgo-UNOFFICIAL-20210207-VANILLA' 02-07 18:18:27.793 2066 2066 F DEBUG : Build fingerprint: 'google/redfin/redfin:11/RQ1A.210205.004/7038034:user/release-keys' 02-07 18:18:27.793 2066 2066 F DEBUG : Revision: '0' 02-07 18:18:27.793 2066 2066 F DEBUG : ABI: 'arm64' 02-07 18:18:27.793 2066 2066 F DEBUG : Timestamp: 2021-02-07 18:18:27+0000 02-07 18:18:27.793 2066 2066 F DEBUG : pid: 497, tid: 889, name: DPPS_THREAD >>> /vendor/bin/hw/[email protected] <<< 02-07 18:18:27.793 2066 2066 F DEBUG : uid: 1000 02-07 18:18:27.793 2066 2066 F DEBUG : signal 6 (SIGABRT), code -1 (SI_QUEUE), fault addr -------- 02-07 18:18:27.793 2066 2066 F DEBUG : Abort message: 'Scudo ERROR: invalid chunk state when deallocating address 0x00790948f320 02-07 18:18:27.793 2066 2066 F DEBUG : ' 02-07 18:18:27.794 2066 2066 F DEBUG : x0 0000000000000000 x1 0000000000000379 x2 0000000000000006 x3 000000785fdfe910 02-07 18:18:27.794 2066 2066 F DEBUG : x4 0000808080808080 x5 0000808080808080 x6 0000808080808080 x7 0000000000000018 02-07 18:18:27.794 2066 2066 F DEBUG : x8 00000000000000f0 x9 7fc1dcea005bf9d8 x10 0000000000000000 x11 ffffffc0ffffffdf 02-07 18:18:27.794 2066 2066 F DEBUG : x12 0000000000000001 x13 0000000000000030 x14 0000000000000030 x15 0000000000000007 02-07 18:18:27.794 2066 2066 F DEBUG : x16 0000007af9bfcc80 x17 0000007af9bde870 x18 000000785f244000 x19 00000000000001f1 02-07 18:18:27.794 2066 2066 F DEBUG : x20 0000000000000379 x21 00000000ffffffff x22 000000790948f320 x23 00000000ffffffff 02-07 18:18:27.794 2066 2066 F DEBUG : x24 000000785fdfecc0 x25 000000785fdfecc0 x26 000000785fdfeff8 x27 00000000000fc000 02-07 18:18:27.794 2066 2066 F DEBUG : x28 000000785fd06000 x29 000000785fdfe990 02-07 18:18:27.794 2066 2066 F DEBUG : lr 0000007af9b922a0 sp 000000785fdfe8f0 pc 0000007af9b922cc pst 0000000000000000 02-07 18:18:27.796 2066 2066 F DEBUG : backtrace: 02-07 18:18:27.796 2066 2066 F DEBUG : #00 pc 000000000004e2cc /apex/com.android.runtime/lib64/bionic/libc.so (abort+164) (BuildId: 82f8e76b97607abb7c56af0c44940157) 02-07 18:18:27.796 2066 2066 F DEBUG : #1 pc 0000000000042910 /apex/com.android.runtime/lib64/bionic/libc.so (scudo::die()+8) (BuildId: 82f8e76b97607abb7c56af0c44940157) 02-07 18:18:27.796 2066 2066 F DEBUG : #2 pc 0000000000042f88 /apex/com.android.runtime/lib64/bionic/libc.so (scudo::ScopedErrorReport::~ScopedErrorReport()+32) (BuildId: 82f8e76b97607abb7c56af0c44940157) 02-07 18:18:27.797 2066 2066 F DEBUG : #3 pc 00000000000431bc /apex/com.android.runtime/lib64/bionic/libc.so (scudo::reportInvalidChunkState(scudo::AllocatorAction, void*)+76) (BuildId: 82f8e76b97607abb7c56af0c44940157) 02-07 18:18:27.797 2066 2066 F DEBUG : #4 pc 00000000000445d8 /apex/com.android.runtime/lib64/bionic/libc.so (scudo::Allocator<scudo::AndroidConfig, &(scudo_malloc_postinit)>::deallocate(void*, scudo::Chunk::Origin, unsigned long, unsigned long)+340) (BuildId: 82f8e76b97607abb7c56af0c44940157) 02-07 18:18:27.797 2066 2066 F DEBUG : #5 pc 00000000000487e0 /vendor/lib64/libdpps.so (AbaOemSvi::FreeXmlParams()+20) (BuildId: 4d5e250316d879baabd55870bc2ff62f) 02-07 18:18:27.797 2066 2066 F DEBUG : #6 pc 0000000000048be4 /vendor/lib64/libdpps.so (AbaSvi::~AbaSvi()+52) (BuildId: 4d5e250316d879baabd55870bc2ff62f) 02-07 18:18:27.797 2066 2066 F DEBUG : #7 pc 0000000000057548 /vendor/lib64/libdpps.so (AbaCoreFeature::~AbaCoreFeature()+108) (BuildId: 4d5e250316d879baabd55870bc2ff62f) 02-07 18:18:27.797 2066 2066 F DEBUG : #8 pc 00000000000575d8 /vendor/lib64/libdpps.so (AbaCoreFeature::~AbaCoreFeature()+16) (BuildId: 4d5e250316d879baabd55870bc2ff62f) 02-07 18:18:27.797 2066 2066 F DEBUG : #9 pc 000000000003126c /vendor/lib64/libdpps.so (AbaContext::~AbaContext()+224) (BuildId: 4d5e250316d879baabd55870bc2ff62f) 02-07 18:18:27.797 2066 2066 F DEBUG : #10 pc 00000000000317b8 /vendor/lib64/libdpps.so (AbaContext::~AbaContext()+16) (BuildId: 4d5e250316d879baabd55870bc2ff62f) 02-07 18:18:27.797 2066 2066 F DEBUG : #11 pc 00000000000365b0 /vendor/lib64/libdpps.so (DppsServer::~DppsServer()+424) (BuildId: 4d5e250316d879baabd55870bc2ff62f) 02-07 18:18:27.797 2066 2066 F DEBUG : #12 pc 00000000000366b8 /vendor/lib64/libdpps.so (DppsServer::~DppsServer()+16) (BuildId: 4d5e250316d879baabd55870bc2ff62f) 02-07 18:18:27.797 2066 2066 F DEBUG : #13 pc 0000000000036840 /vendor/lib64/libdpps.so (DppsServer::DeleteInstance()+228) (BuildId: 4d5e250316d879baabd55870bc2ff62f) 02-07 18:18:28.007 2066 2066 F DEBUG : #14 pc 00000000000736a8 /vendor/lib64/libdpps.so (DppsImpl::ProcessDppsThread()+296) (BuildId: 4d5e250316d879baabd55870bc2ff62f) 02-07 18:18:28.008 2066 2066 F DEBUG : #15 pc 000000000007347c /vendor/lib64/libdpps.so (DppsImpl::DppsThread(void*)+8) (BuildId: 4d5e250316d879baabd55870bc2ff62f) 02-07 18:18:28.008 2066 2066 F DEBUG : #16 pc 00000000000afd4c /apex/com.android.runtime/lib64/bionic/libc.so (__pthread_start(void*)+64) (BuildId: 82f8e76b97607abb7c56af0c44940157) 02-07 18:18:28.008 2066 2066 F DEBUG : #17 pc 0000000000050288 /apex/com.android.runtime/lib64/bionic/libc.so (__start_thread+64) (BuildId: 82f8e76b97607abb7c56af0c44940157) Change-Id: I5218195eafcdf89dfbe8e46d47220da07d27e89d
mg712702
pushed a commit
that referenced
this pull request
Mar 21, 2021
Fix C2 brightness curve to reflect typical display peak brightness. Since both C2 and F2 devices have linear brightness curves, this CL also simplifies the brightness setting by omitting unnecessary LUT entries and moving the brightness curves to a common overlay. Bug: 136293167 Test: Manually tested F2 and C2 by shining a flashlight at the ALS and doing the following: 1) Read mLastObservedLux and mScreenAutoBrightness (adb shell dumpsys display) 2) Find out the target nits value from config_autoBrightnessLevels and config_autoBrightnessDisplayValuesNits, using mLastObservedLux 3) Calculate the predicted display nits assuming a linear mapping from [1, 255] to [2 nits, 450 nits], for the read mScreenAutoBrightness 4) Compare results from #3 and #2 5) Repeat for F2 and C2, for 3 lux points Change-Id: Iaa221cf9f5169a0fbd08abec492518c58c134e38 Signed-off-by: Mrinal Ghosh <[email protected]>
ghost
pushed a commit
to Descendant-Devices/android_device_xiaomi_ginkgo
that referenced
this pull request
Aug 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.