Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ginkgo: Update #2 #3

Closed
wants to merge 23 commits into from
Closed

ginkgo: Update #2 #3

wants to merge 23 commits into from

Conversation

cyberwalkman
Copy link
Contributor

  • Fixes for brightness, now the brightness is adjusted correctly over the entire range of values.
  • If the ROM already contains NoCutoutOverlay package (PixelExperience, for example), then instead of all the commits related to it, it’s enough to use only this one - https://github.com/cyberwalkman/device_xiaomi_ginkgo/commit/b2964264ad1966a51cc9138c802da6824bf817a4
  • I tested the dynamic selection of the dalvik config (without the config in device.mk) on my device, but it would be nice to check this on devices with 3 and 6GB RAM.

cyberwalkman and others added 23 commits May 18, 2020 20:33
@cyberwalkman
Revert "ginkgo: lights: [HAX] Never use 1 as minimum brightness"
0a41027 
This reverts commit 278f844.

Change-Id: Icb284e43bb981603fea6046b1ae44d5b1ce4166f
@vasishath @cyberwalkman
ginkgo: Detect maximum brightness dynamically
dd4f06a 
 * Instead of hardcoding the value.

Change-Id: I9385be40a8598e1142bb3844446b6bbeb5aab008
@PeterCxy @cyberwalkman
ginkgo: light: Drop support for adjustable breathing
5cf757b 
* This does not work, and the result is simply blinking but not
  breathing. I don't know what it's supposed to be, but this really
  looks bad and let's just resort to a fixed-rate breathing.

Change-Id: Icebd388b0eda130dbd5a251950374566588ad022
@Demon000 @cyberwalkman
ginkgo: light: avoid resetting state
313b3b4 
The handler function is called regardless of whether the value of the
highest priority state changed.
In case of the notification led, this translates to the breathing
process being reset, which triggers my OCD.

Change-Id: I4880b00602cbb739219871f1d7ce9ad85d87bc1b
@Demon000 @cyberwalkman
ginkgo: light: do not turn on breathing for unlit hardware states
71f0fc0 
Change-Id: I093fb2fb81012a473eda232d3c3407d0e0791907
@Demon000 @cyberwalkman
ginkgo: light: simplify alpha scaling logic
fab0ac9 
Change-Id: I9b5c15d5ec4865d3bf829457d6f110ddb3af6e94
@cyberwalkman
ginkgo: light: Update init .rc file
25ce05e 
Change-Id: Ibf52939613e36f14a90f296c170f8a3580aad170
@cyberwalkman
ginkgo: overlay: Use stock brightness configuration
b302919 
 * This does not include config_brightness_ramp_rate values,
   as AOSP values ​​are better suited.
 * Slight reorganizations and cleanup

Change-Id: I484b484ca045f370bd5da6a69dfaeee972b0d50e
@PeterCxy @cyberwalkman
ginkgo: overlay: scale auto brightness curve to [1, 255]
bda5be4 
* This is what it should be.

Change-Id: Iab2201b1ad0340994e8defb62d77be3d649f9784
@cyberwalkman
ginkgo: overlay: Correct brightness values
10f6f8e 
 * Correct brightness values ​​in accordance with auto-brightness curve

Change-Id: I3dbeb7b35c779aeef3ce0bfd718edd88f313c291
@cyberwalkman
ginkgo: overlay: Set maximum brightness to 256
b39130b 
* Reason: PeterCxy/android_device_xiaomi_picasso@3c5dfe7

Change-Id: I89f39b2cc979e4263e16667556e3795c91f2b412
@cyberwalkman
ginkgo: Update vibration patterns from stock
83c34c2 
 * Xiaomi uses AOSP values for ginkgo, so duplicate values ​​can be also removed.

Change-Id: I4fd852962dd7af4084e1b070ccb4a7e66442cac4
@cyberwalkman
ginkgo: overlay: Correct statusbar height and notch cutout
7998105 
 * Values from stock

Change-Id: I1710a235e7552214172615515efad2a5622c8407
@adrianroos @cyberwalkman
ginkgo: Add overlay for masking the notch
bf1fc2b 
Bug: 112876936
Test: Go to Settings > Developer Options > Simulate display with cutout > "No cutout". Cutout should be hidden. Rotate screen, take screenshots, screenrecord should all work.
Change-Id: I66684d8254fd3c1ee6851e67c0b09d176d4c02af
(cherry picked from commit dcc48dc9071c37c8b9fe7caee96585d20d149060)
@adrianroos @cyberwalkman
ginkgo: Leverage hide string for display_cutout_emulation_overlay
d8be79e 
Bug: 112876936
Test: manual
Change-Id: Ibcefa4b50713c451a398409c1bc941cd833921f2
(cherry picked from commit 2a3d90837c0811ce31705ae135e5eb517f38403b)
@luca020400 @cyberwalkman
ginkgo: Install NoCutoutOverlay to system
bbc6ada 
Change-Id: I26b6277e89ff9a26daa7d2ae16c50e873eddecfa
@1nfrag @cyberwalkman
ginkgo: Build NoCutoutOverlay
4de2649 
Change-Id: I94d80335f58217d0af91273ad1ae476f69ba07a9
@luk1337 @cyberwalkman
ginkgo: Set default clock position to left
4973218 
Change-Id: I2b597579851434972cd29510ff90dfa8ddc6564f
@jesec @cyberwalkman
ginkgo: overlay: Enable option for full screen aspect ratio
5b1acde 
Change-Id: I2a1b2acc5ed97ccb6795dc371c2b3ac9cb4f9d03
@danw @cyberwalkman
ginkgo: Switch from add_lunch_combo to COMMON_LUNCH_CHOICES
a14ed79 
Bug: 77599627
Test: lunch  [see entries in list]
Change-Id: Id44fcfec47eeb979a745f879031f1bec7359a633
@jiyongp @cyberwalkman
ginkgo: Add updatable_apex.mk
2294e93 
The product abstracts configs that need to be set to support updating of APEXes.

Change-Id: Id5aa944ceba6a6846308f1c18a08af8b3bb38589
@cyberwalkman
ginkgo: Update lineage.dependencies
fdb4642 
Change-Id: I83049c1082ea9a606134f72c649704aada9d60bd
@cyberwalkman
ginkgo: Set dalvik-heap configuration dynamically
c9142bc 
 * We have devices with 3, 4 and 6(ginkgo only)GB RAM.
 * We can leave 4GB config in device.mk for those cases,
   when libinit does not work, for example in GSI builds.

Change-Id: I5eef1e092e54444c73bd3f92bba7291a54321253
@mg712702 mg712702 closed this May 28, 2020
mg712702 pushed a commit that referenced this pull request Oct 18, 2020
@mg712702
ginkgo: Update C2 and F2 brightness curves
3186bea 
Fix C2 brightness curve to reflect typical display peak brightness.
Since both C2 and F2 devices have linear brightness curves, this CL also
simplifies the brightness setting by omitting unnecessary LUT entries
and moving the brightness curves to a common overlay.

Bug: 136293167
Test: Manually tested F2 and C2 by shining a flashlight at the ALS and
    doing the following:
    1) Read mLastObservedLux and mScreenAutoBrightness (adb shell
    dumpsys display)
    2) Find out the target nits value from config_autoBrightnessLevels
    and config_autoBrightnessDisplayValuesNits, using mLastObservedLux
    3) Calculate the predicted display nits assuming a linear mapping
    from [1, 255] to [2 nits, 450 nits], for the read
    mScreenAutoBrightness
    4) Compare results from #3 and #2
    5) Repeat for F2 and C2, for 3 lux points
Change-Id: Iaa221cf9f5169a0fbd08abec492518c58c134e38
Signed-off-by: Mrinal Ghosh <[email protected]>
mg712702 pushed a commit that referenced this pull request Oct 18, 2020
@mg712702
ginkgo: Update C2 and F2 brightness curves
8951e3f 
Fix C2 brightness curve to reflect typical display peak brightness.
Since both C2 and F2 devices have linear brightness curves, this CL also
simplifies the brightness setting by omitting unnecessary LUT entries
and moving the brightness curves to a common overlay.

Bug: 136293167
Test: Manually tested F2 and C2 by shining a flashlight at the ALS and
    doing the following:
    1) Read mLastObservedLux and mScreenAutoBrightness (adb shell
    dumpsys display)
    2) Find out the target nits value from config_autoBrightnessLevels
    and config_autoBrightnessDisplayValuesNits, using mLastObservedLux
    3) Calculate the predicted display nits assuming a linear mapping
    from [1, 255] to [2 nits, 450 nits], for the read
    mScreenAutoBrightness
    4) Compare results from #3 and #2
    5) Repeat for F2 and C2, for 3 lux points
Change-Id: Iaa221cf9f5169a0fbd08abec492518c58c134e38
Signed-off-by: Mrinal Ghosh <[email protected]>
mg712702 pushed a commit that referenced this pull request Mar 8, 2021
@adithya2306
ginkgo: Disable display SVI for now
e048254 
 * crashes HWC due to a double-free in libdpps:

02-07 18:18:27.793  2066  2066 F DEBUG   : *** *** *** *** *** *** *** *** *** *** *** *** *** *** *** ***
02-07 18:18:27.793  2066  2066 F DEBUG   : ArrowOS Version: 'Arrow-v11.0-ginkgo-UNOFFICIAL-20210207-VANILLA'
02-07 18:18:27.793  2066  2066 F DEBUG   : Build fingerprint: 'google/redfin/redfin:11/RQ1A.210205.004/7038034:user/release-keys'
02-07 18:18:27.793  2066  2066 F DEBUG   : Revision: '0'
02-07 18:18:27.793  2066  2066 F DEBUG   : ABI: 'arm64'
02-07 18:18:27.793  2066  2066 F DEBUG   : Timestamp: 2021-02-07 18:18:27+0000
02-07 18:18:27.793  2066  2066 F DEBUG   : pid: 497, tid: 889, name: DPPS_THREAD  >>> /vendor/bin/hw/[email protected] <<<
02-07 18:18:27.793  2066  2066 F DEBUG   : uid: 1000
02-07 18:18:27.793  2066  2066 F DEBUG   : signal 6 (SIGABRT), code -1 (SI_QUEUE), fault addr --------
02-07 18:18:27.793  2066  2066 F DEBUG   : Abort message: 'Scudo ERROR: invalid chunk state when deallocating address 0x00790948f320
02-07 18:18:27.793  2066  2066 F DEBUG   : '
02-07 18:18:27.794  2066  2066 F DEBUG   :     x0  0000000000000000  x1  0000000000000379  x2  0000000000000006  x3  000000785fdfe910
02-07 18:18:27.794  2066  2066 F DEBUG   :     x4  0000808080808080  x5  0000808080808080  x6  0000808080808080  x7  0000000000000018
02-07 18:18:27.794  2066  2066 F DEBUG   :     x8  00000000000000f0  x9  7fc1dcea005bf9d8  x10 0000000000000000  x11 ffffffc0ffffffdf
02-07 18:18:27.794  2066  2066 F DEBUG   :     x12 0000000000000001  x13 0000000000000030  x14 0000000000000030  x15 0000000000000007
02-07 18:18:27.794  2066  2066 F DEBUG   :     x16 0000007af9bfcc80  x17 0000007af9bde870  x18 000000785f244000  x19 00000000000001f1
02-07 18:18:27.794  2066  2066 F DEBUG   :     x20 0000000000000379  x21 00000000ffffffff  x22 000000790948f320  x23 00000000ffffffff
02-07 18:18:27.794  2066  2066 F DEBUG   :     x24 000000785fdfecc0  x25 000000785fdfecc0  x26 000000785fdfeff8  x27 00000000000fc000
02-07 18:18:27.794  2066  2066 F DEBUG   :     x28 000000785fd06000  x29 000000785fdfe990
02-07 18:18:27.794  2066  2066 F DEBUG   :     lr  0000007af9b922a0  sp  000000785fdfe8f0  pc  0000007af9b922cc  pst 0000000000000000
02-07 18:18:27.796  2066  2066 F DEBUG   : backtrace:
02-07 18:18:27.796  2066  2066 F DEBUG   :       #00 pc 000000000004e2cc  /apex/com.android.runtime/lib64/bionic/libc.so (abort+164) (BuildId: 82f8e76b97607abb7c56af0c44940157)
02-07 18:18:27.796  2066  2066 F DEBUG   :       #1 pc 0000000000042910  /apex/com.android.runtime/lib64/bionic/libc.so (scudo::die()+8) (BuildId: 82f8e76b97607abb7c56af0c44940157)
02-07 18:18:27.796  2066  2066 F DEBUG   :       #2 pc 0000000000042f88  /apex/com.android.runtime/lib64/bionic/libc.so (scudo::ScopedErrorReport::~ScopedErrorReport()+32) (BuildId: 82f8e76b97607abb7c56af0c44940157)
02-07 18:18:27.797  2066  2066 F DEBUG   :       #3 pc 00000000000431bc  /apex/com.android.runtime/lib64/bionic/libc.so (scudo::reportInvalidChunkState(scudo::AllocatorAction, void*)+76) (BuildId: 82f8e76b97607abb7c56af0c44940157)
02-07 18:18:27.797  2066  2066 F DEBUG   :       #4 pc 00000000000445d8  /apex/com.android.runtime/lib64/bionic/libc.so (scudo::Allocator<scudo::AndroidConfig, &(scudo_malloc_postinit)>::deallocate(void*, scudo::Chunk::Origin, unsigned long, unsigned long)+340) (BuildId: 82f8e76b97607abb7c56af0c44940157)
02-07 18:18:27.797  2066  2066 F DEBUG   :       #5 pc 00000000000487e0  /vendor/lib64/libdpps.so (AbaOemSvi::FreeXmlParams()+20) (BuildId: 4d5e250316d879baabd55870bc2ff62f)
02-07 18:18:27.797  2066  2066 F DEBUG   :       #6 pc 0000000000048be4  /vendor/lib64/libdpps.so (AbaSvi::~AbaSvi()+52) (BuildId: 4d5e250316d879baabd55870bc2ff62f)
02-07 18:18:27.797  2066  2066 F DEBUG   :       #7 pc 0000000000057548  /vendor/lib64/libdpps.so (AbaCoreFeature::~AbaCoreFeature()+108) (BuildId: 4d5e250316d879baabd55870bc2ff62f)
02-07 18:18:27.797  2066  2066 F DEBUG   :       #8 pc 00000000000575d8  /vendor/lib64/libdpps.so (AbaCoreFeature::~AbaCoreFeature()+16) (BuildId: 4d5e250316d879baabd55870bc2ff62f)
02-07 18:18:27.797  2066  2066 F DEBUG   :       #9 pc 000000000003126c  /vendor/lib64/libdpps.so (AbaContext::~AbaContext()+224) (BuildId: 4d5e250316d879baabd55870bc2ff62f)
02-07 18:18:27.797  2066  2066 F DEBUG   :       #10 pc 00000000000317b8  /vendor/lib64/libdpps.so (AbaContext::~AbaContext()+16) (BuildId: 4d5e250316d879baabd55870bc2ff62f)
02-07 18:18:27.797  2066  2066 F DEBUG   :       #11 pc 00000000000365b0  /vendor/lib64/libdpps.so (DppsServer::~DppsServer()+424) (BuildId: 4d5e250316d879baabd55870bc2ff62f)
02-07 18:18:27.797  2066  2066 F DEBUG   :       #12 pc 00000000000366b8  /vendor/lib64/libdpps.so (DppsServer::~DppsServer()+16) (BuildId: 4d5e250316d879baabd55870bc2ff62f)
02-07 18:18:27.797  2066  2066 F DEBUG   :       #13 pc 0000000000036840  /vendor/lib64/libdpps.so (DppsServer::DeleteInstance()+228) (BuildId: 4d5e250316d879baabd55870bc2ff62f)
02-07 18:18:28.007  2066  2066 F DEBUG   :       #14 pc 00000000000736a8  /vendor/lib64/libdpps.so (DppsImpl::ProcessDppsThread()+296) (BuildId: 4d5e250316d879baabd55870bc2ff62f)
02-07 18:18:28.008  2066  2066 F DEBUG   :       #15 pc 000000000007347c  /vendor/lib64/libdpps.so (DppsImpl::DppsThread(void*)+8) (BuildId: 4d5e250316d879baabd55870bc2ff62f)
02-07 18:18:28.008  2066  2066 F DEBUG   :       #16 pc 00000000000afd4c  /apex/com.android.runtime/lib64/bionic/libc.so (__pthread_start(void*)+64) (BuildId: 82f8e76b97607abb7c56af0c44940157)
02-07 18:18:28.008  2066  2066 F DEBUG   :       #17 pc 0000000000050288  /apex/com.android.runtime/lib64/bionic/libc.so (__start_thread+64) (BuildId: 82f8e76b97607abb7c56af0c44940157)

Change-Id: I5218195eafcdf89dfbe8e46d47220da07d27e89d
mg712702 pushed a commit that referenced this pull request Mar 21, 2021
@mg712702
ginkgo: Update C2 and F2 brightness curves
788dec8 
Fix C2 brightness curve to reflect typical display peak brightness.
Since both C2 and F2 devices have linear brightness curves, this CL also
simplifies the brightness setting by omitting unnecessary LUT entries
and moving the brightness curves to a common overlay.

Bug: 136293167
Test: Manually tested F2 and C2 by shining a flashlight at the ALS and
    doing the following:
    1) Read mLastObservedLux and mScreenAutoBrightness (adb shell
    dumpsys display)
    2) Find out the target nits value from config_autoBrightnessLevels
    and config_autoBrightnessDisplayValuesNits, using mLastObservedLux
    3) Calculate the predicted display nits assuming a linear mapping
    from [1, 255] to [2 nits, 450 nits], for the read
    mScreenAutoBrightness
    4) Compare results from #3 and #2
    5) Repeat for F2 and C2, for 3 lux points
Change-Id: Iaa221cf9f5169a0fbd08abec492518c58c134e38
Signed-off-by: Mrinal Ghosh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.