Replace Map<number, T> with sparse array in DFAState #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
April 11, 2020 16:46
Use a relative path devDependency on antlr4ts-cli, that's cleaner. Add steps to cleanup any npm global mess made before. Added 'npm run reinstall' script for clean-up of truly ugly problems. Note: reinstall involves a 'git purge -idx'. It asks permission...
Workaround for #458
Disentangle imports / directory reorg Makes antlr4ts more like the other ANTLR4 target directory structure Build process now split out for packages, with each getting it's own package.json, and tsconfig.json. Eliminate relative path imports anywhere outside the src/ directory. checking in .d.ts files to track any api changes
Note: currently TypeScript v3.x is problematic in this context, but 2.9 is OK
Implements suggestion in PR #454
Version 3.8.3 generates errors that don't seem right, so 3.7.5 it is. Getting to V3.x gets us the new project build mode, which is a big win in terms of build time. tsc will use tsconfig.tsbuildinfo files to manage an incremental compile which can really speed up many situations. Switches used on tsc commands change for this mode. One copy of the compiler, set in --watch mode, and watch the entire directory tree, performing compiles on change even if different parts of the tree uses different settings. Making this work right requires a change in import statments. None of them should ever reference the "src" directory, if needed use "dist" instead.
…sitory To run antlr, we use the `lerna run antlr` command. Any package that has an antlr script is run, lerna controls the ordering based on dependencies declared in the package.json files. The typescript compiler has multi-package build-in (in V3+). Combined with a new incremetal compile feature, this is a big time savings.
Fixes: #459 Yet more fixes for tslint gripes
…e pdd (describe()/it()) style test ui
internal.ts becomes the single controlling point for module load order fixes: #466
sharwell
reviewed
Apr 29, 2020
| @@ -59,12 +59,17 @@ export class DFASerializer { | |||
| states.sort((o1, o2) => o1.stateNumber - o2.stateNumber); | |||
|
|
|||
| for (const s of states) { | |||
| const edges: Map<number, DFAState> = s.getEdgeMap(); | |||
| const edges: Array<DFAState> = s.getEdgeMap(); | |||
There was a problem hiding this comment.
💭 Why Array<DFAState> instead of DFAState[]? I'm sure I used to know the answer...
There was a problem hiding this comment.
They are the same thing. It just was easier to textually substitute without changing the trailing '>'.
There was a problem hiding this comment.
Nice to hear from you.
There was a problem hiding this comment.
P.S. most of these changes are from earlier PR #454.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Interesting little optimization, possible because JavaScript Arrays are sparse. Up to 17% improvement in lexer speed. See #467.
@sharwell your feedback would be interesting. I (still) don't understand
PredictionContext.EMPTY_FULL_STATE_KEY, and how it is treated in this code.Are the other opportunities listed in #467 at all likely to make significant differences?