Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add quadratic mesh element types #656

Merged
merged 10 commits into from
May 7, 2015

Conversation

norihiro-w
Copy link
Collaborator

This PR implements quadratic version of Tri, Tet, Hex, Prism and Pyramid elements in MeshLib. I also tried to involve them in InSituLib.

@bilke
Copy link
Member

bilke commented Apr 24, 2015

Maybe for PRISM15 we also have to do a reordering of the nodes as for PRISM6. Otherwise 👍

@norihiro-w norihiro-w force-pushed the add-quadratic-cells branch 2 times, most recently from f06b2ab to d3b7c48 Compare April 24, 2015 10:18
@norihiro-w
Copy link
Collaborator Author

@bilke I added a reordering of the nodes for PRISM15

@@ -144,39 +145,40 @@ int VtkMeshSource::RequestData( vtkInformation* request,
for (unsigned j = 0; j < nElemNodes; ++j)
point_ids->SetId(j, elem->getNode(j)->getID());

switch (elem->getGeomType())
type = OGSToVtkCellType(elem->getCellType());
if (type==0)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A constant 0 could potentially change. Better to use something along

if (type == CellType::INVALID)

(Introduce it if necessary).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@endJunction
Copy link
Member

@endJunction
Copy link
Member

Rebased w/o conflicts on master and merged.

@endJunction endJunction closed this May 7, 2015
@endJunction endJunction reopened this May 7, 2015
endJunction added a commit that referenced this pull request May 7, 2015
@endJunction endJunction merged commit 8ffdcfe into ufz:master May 7, 2015
endJunction added a commit that referenced this pull request May 7, 2015
@norihiro-w norihiro-w deleted the add-quadratic-cells branch June 9, 2015 07:42
@ogsbot
Copy link
Member

ogsbot commented Jun 19, 2020

OpenGeoSys development has been moved to GitLab.

See this pull request on GitLab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants