Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete linear and quadratic FE types #657

Merged
merged 10 commits into from
May 20, 2015
Merged

Conversation

norihiro-w
Copy link
Collaborator

as titled. this PR should be merged after #656

@norihiro-w
Copy link
Collaborator Author

note for myself. there is a bug in getting weight for prism. one should use W instead of X.

class HexRule20 : public HexRule8
{
public:
/// Constant: The number of all nodes for this element
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

of this element.

@norihiro-w
Copy link
Collaborator Author

updated and rebased

@wenqing
Copy link
Member

wenqing commented May 20, 2015

👍

getNPoints(std::size_t order)
{
if (order==2) return 6;
return 0;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the 0 return value correct?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, at the moment, only order of 2 is supported for prism

endJunction added a commit that referenced this pull request May 20, 2015
Complete linear and quadratic FE types
@endJunction endJunction merged commit 8af1a41 into ufz:master May 20, 2015
@norihiro-w norihiro-w mentioned this pull request May 20, 2015
@norihiro-w norihiro-w deleted the add-fe-types branch May 20, 2015 15:19
@ogsbot
Copy link
Member

ogsbot commented Jun 19, 2020

OpenGeoSys development has been moved to GitLab.

See this pull request on GitLab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants