-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Complete linear and quadratic FE types #657
Conversation
ca1f932
to
1f9fba5
Compare
note for myself. there is a bug in getting weight for prism. one should use W instead of X. |
b10aa62
to
e1e494e
Compare
class HexRule20 : public HexRule8 | ||
{ | ||
public: | ||
/// Constant: The number of all nodes for this element |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
of this element.
It's hard to test this because, for higher order elements, integrated matrix values can vary depending on the order.
updated and rebased |
👍 |
getNPoints(std::size_t order) | ||
{ | ||
if (order==2) return 6; | ||
return 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the 0 return value correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, at the moment, only order of 2 is supported for prism
Complete linear and quadratic FE types
OpenGeoSys development has been moved to GitLab. |
as titled. this PR should be merged after #656