Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

global is not defined #119

Closed
ccqgithub opened this issue Mar 16, 2018 · 2 comments
Closed

global is not defined #119

ccqgithub opened this issue Mar 16, 2018 · 2 comments

Comments

@ccqgithub
Copy link

ccqgithub commented Mar 16, 2018 •
edited
Loading

thorw error global is not defined in browser
@3rd-Eden
Copy link
Member

3rd-Eden commented Mar 16, 2018 •
edited
Loading

So is require, so we assume that your build system e.g. webpack or browserify introduces that (which they do).

@lpinca lpinca closed this as completed Apr 9, 2018
@ycros
Copy link

ycros commented Aug 16, 2018

Angular 6 and their build system (angular-cli, uses webpack underneath) has dropped support for this shim as it's a nodejs thing - angular/angular-cli#9827 (comment)

benland pushed a commit to benland/url-parse that referenced this issue Oct 23, 2018
global is not defined unshiftio#119
a4086e4
@benland benland mentioned this issue Oct 23, 2018
Merged
3rd-Eden pushed a commit that referenced this issue Nov 5, 2018
@benland @3rd-Eden
[fix] global is not defined (#160)
7781ad8 
* global is not defined #119
* better handling of global
* Co-Authored-By: benland <[email protected]>
* globalVar is always defined
* Co-Authored-By: benland <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ycros @3rd-Eden @lpinca @ccqgithub