Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

global is not defined #160

Merged
merged 3 commits into from
Nov 5, 2018
Merged

global is not defined #160

merged 3 commits into from
Nov 5, 2018

Conversation

benland
Copy link
Contributor

@benland benland commented Oct 23, 2018

global is not defined in the browser.
global && global.location throw an exception.

Angular CLI decided not to inject global to window.
#119 (comment)

index.js Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
@lpinca
Copy link
Member

lpinca commented Nov 4, 2018

@3rd-Eden LGTY?

@3rd-Eden
Copy link
Member

3rd-Eden commented Nov 5, 2018

YUP!

@3rd-Eden 3rd-Eden merged commit 7781ad8 into unshiftio:master Nov 5, 2018
@3rd-Eden
Copy link
Member

3rd-Eden commented Nov 5, 2018

Released as 1.4.4 -- Thanks for your contribution <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants