Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for pickProcess with remote debugging via platformInitCommands #1001

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nkronlage
Copy link

I'd love to be able to use ${command:pickProcess} with remote debugging to Android but that currently did not work because the platform process list command issued by pickProcess does not let you specify the remote platform.

This is a proposal to have a "platformInitCommands" list that is used both in debugger setup and in pickProcess to let you select/connect the platform.

Here's an example of using `"pid": "${command:pickProcess}" when debugging on an Android emulator:

image

@vadimcn
Copy link
Owner

vadimcn commented Sep 30, 2023

Good idea! However, I don't like the proliferation of extra options. Can you think of any reason initCommands can't be used for process picker?

@nkronlage
Copy link
Author

That should be ok! Was worried about breaking people if they do something that doesn't work well with pickProcess in their initCommands. But pickProcess never really worked with remote stuff before so that shouldn't be a problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants