-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add filter option to pickProcess command #1002
base: master
Are you sure you want to change the base?
Conversation
Let's not overload |
17251db
to
502fea5
Compare
Good idea. How does this look? Note, I couldn't find a way to access the config's initCommands from the input variable so you have to duplicate them. LMK if you know of a way to pass those around. |
Ah, I was not aware of this difference in the command invocation. I can think of a couple of ways of doing it:
On the other hand, standard variable resolution is, well, standard. So I'm kinda leaning towards the way it's implemented in your PR. |
502fea5
to
606b7a5
Compare
606b7a5
to
a6e55ac
Compare
I work in the Chromium code base which uses several different processes.
It'd be very convenient if the pickProcess list was filtered to just the processes I care about.
Here's a potential change to let you filter the process list by using the existing "program" option.
Here's what I put in my launch config:
And here's the result:
Note, this builds on #1001 to get the config in to pickProcess