Skip to content

Commit

Permalink
sagemathgh-38303: Fix DrinfeldModule is_isomorphic method absolutely'…
Browse files Browse the repository at this point in the history
… flag

    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

Fixes sagemath#38276.

@xcaruso @DavidAyotte @ymusleh

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [X] The title is concise and informative.
- [X] The description explains in detail what this PR is about.
- [X] I have linked a relevant issue or discussion.
- [X] I have created tests covering the changes.
- [X] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#38303
Reported by: Antoine Leudière
Reviewer(s): Travis Scrimshaw, Xavier Caruso
  • Loading branch information
Release Manager committed Jul 20, 2024
2 parents 22dbf40 + 611bd42 commit eb8c97f
Showing 1 changed file with 14 additions and 2 deletions.
16 changes: 14 additions & 2 deletions src/sage/rings/function_field/drinfeld_modules/drinfeld_module.py
Original file line number Diff line number Diff line change
Expand Up @@ -1292,9 +1292,9 @@ def is_isomorphic(self, other, absolutely=False):
INPUT:
- ``absolutely`` -- a boolean (default: ``False``); if ``True``,
- ``absolutely`` -- a boolean (default: ``False``); if ``False``,
check the existence of an isomorphism defined on the base
field; if ``False``, check over an algebraic closure.
field; if ``True``, check over an algebraic closure.
EXAMPLES::
Expand Down Expand Up @@ -1328,6 +1328,18 @@ def is_isomorphic(self, other, absolutely=False):
sage: phi.is_isomorphic(psi, absolutely=True)
True
In particular, two Drinfeld modules may have the same
`j`-invariant, while not being isomorphic on the base field::
sage: phi = DrinfeldModule(A, [z, 0, 1])
sage: psi = DrinfeldModule(A, [z, 0, z])
sage: phi.j_invariant() == psi.j_invariant()
True
sage: phi.is_isomorphic(psi)
False
sage: phi.is_isomorphic(psi, absolutely=True)
True
On certain fields, testing isomorphisms over the base field may
fail::
Expand Down

0 comments on commit eb8c97f

Please sign in to comment.