Add timestamp on backup files #52
Conversation
Signed-off-by: lbgracioso <[email protected]>
|
|
Hi @lbgracioso did you took a chance to look at the comments on this one? |
Signed-off-by: Lucas Gracioso <[email protected]>
|
@viniciusferrao Can you please check it again? |
| * \brief Get the current timestamp as a string. | ||
| * | ||
| * This function generates the current timestamp in the format | ||
| * "YYYYMMDD_HHMMSS". |
There was a problem hiding this comment.
Docs needs to be also updated.
| time_t now; | ||
| time(&now); | ||
| char buf[sizeof "2011-10-08T07:07:09Z"]; | ||
| strftime(buf, sizeof buf, "%FT%TZ", gmtime(&now)); |
There was a problem hiding this comment.
Why not use chrono instead?
strftime is a C directive that's available on ctime and we should definitely avoid using legacy C functions.
There was a problem hiding this comment.
Yes, this can be done with chrono
https://en.cppreference.com/w/cpp/chrono
There was a problem hiding this comment.
Need to use stringstream if using chrono. Already discussed with @viniciusferrao
There was a problem hiding this comment.
The beautiful thing of C++ is the legacy that we have. There's probably a way to completely ditch stringstream because it sucks and we have std::format now, however we just need to find a way to use it with chrono.
|
Dropping it because #64 is already merged. |
|
I've merged wrong @arthurmco? |
This PR adds the current timestamp (ISO 8601 like) to the end of the backup file names
Example: Created a backup copy of /etc/exports on /opt/cloysterhpc/backup/etc/exports_2024-06-19T11:08:45Z