Add timestamp on backup files, C++11 version #64
Conversation
Signed-off-by: lbgracioso <[email protected]>
Signed-off-by: Lucas Gracioso <[email protected]>
|
LGTM. |
arthurmco
changed the title
|
| CPMFindPackage(NAME spdlog) | ||
| CPMFindPackage(NAME spdlog | ||
| OPTIONS | ||
| "SPDLOG_FMT_EXTERNAL ON") |
There was a problem hiding this comment.
Does that works when using Conan instead of CPM?
There was a problem hiding this comment.
Probably not... but I used conan and it worked.
There was a problem hiding this comment.
Well whatever. That may be an issue at some point but may be not. If not we gonna open a bug for this.
The root of the problem here is that CPM seems to be the way forward for Package Management, but there's some packages that aren't available yet. So we rely on Conan for it.
A bigger issue will be when we move to std::format... what if this PR breaks with it?
There was a problem hiding this comment.
CPM seems to download packages from github repositories, so the "non-presence" might not be a problem.
Regarding std::format, it supports formatting chrono data types (source):
For chrono types, the format specification is interpreted as chrono format specification.
Implements changes called on #52, but using C++11
This PR is also a superset of #52, so commits there will appear here.
(I would add there, but Github did not let me...)