Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Not all file names follow the same convention #1748

Closed
molant opened this issue Jan 23, 2019 · 2 comments
Closed

[Bug] Not all file names follow the same convention #1748

molant opened this issue Jan 23, 2019 · 2 comments
Labels
difficulty:easy good first issue type:bug

Comments

@molant
Copy link
Member

molant commented Jan 23, 2019

🐛 Bug report

Description

All files should be lower case and dash separated. There are some that don't follow this convention such as fetchContent.ts in connector-chrome.
@karansapolia
Copy link
Contributor

There are more files in packages/hint/src/lib/enums , namely hintscope.ts, errorstatus.ts, resourcetype.ts which do not follow the convention. Possibly there are more. If renaming the files does not cause anything to break, I would be more than happy to do the legwork here :-). Should I go ahead with it?

@molant
Copy link
Member Author

molant commented Feb 6, 2019

Renaming shouldn't break anything as long as the references are updated in the code. Please go ahead and thank you!

karansapolia added a commit to karansapolia/hint that referenced this issue Feb 7, 2019
@karansapolia
Fix: Refactor for file name convention
6b036a3 
Rename files which do not follow naming convention of
lower case dash seperated file names. Update all references
changed file names.

 - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -

Fix webhintio#1748
@karansapolia karansapolia mentioned this issue Feb 7, 2019
Merged
3 tasks
molant pushed a commit to karansapolia/hint that referenced this issue Feb 11, 2019
@karansapolia @molant
Fix: Refactor for file name convention
ef69d59 
Rename files which do not follow naming convention of
lower case dash seperated file names. Update all references
changed file names.

 - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -

Fix webhintio#1748
@molant molant mentioned this issue Feb 11, 2019
Closed
2 tasks
molant pushed a commit that referenced this issue Feb 11, 2019
@karansapolia @molant
Fix: Refactor for file name convention (#1861)
44674e9 
Rename files which do not follow naming convention of lower case
dash seperated file names. Update all references changed file
names.

- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -

Fix #1748
Close #1861
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty:easy good first issue type:bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: Refactor for file name convention webhintio/hint
2 participants
@molant @karansapolia