Fix: Refactor for file name convention #1861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karansapolia
requested review from
antross,
molant and
sarvaje
as code owners
sarvaje
approved these changes
Feb 7, 2019
|
@karansapolia I plan on merging this as soon as we resolve some issues we are having with TypeScript with some of the other PRs. If there are any conflicts after we merge those I'll take care of them. Thanks again! |
Rename files which do not follow naming convention of lower case dash seperated file names. Update all references changed file names. - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - Fix webhintio#1748
molant
force-pushed
the
naming-convention-fix
branch
from
6b036a3
to
ef69d59
Compare
|
I've rebased with the latest |
|
Yay! 😊🤞🏻 |
|
For whatever reason GitHub is not linking to the right results. The correct ones are https://dev.azure.com/webhint/webhint/_build/results?buildId=1608 and all are green: |
|
Congratulations in your first merged PR @karansapolia 🎉 |
|
Thank you so much! You have been very supportive! Looking forward to many more PRs 😃😋 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Make sure you:
For non-trivial changes, please make sure you also:
Added/Updated related documentation.Short description of the change(s)
Rename files which do not follow naming convention of
lower case dash seperated file names. Update all references
changed file names.
Fix #1748