Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dotnet] Fix detecting if the interpreter is enabled. #19812

Merged
merged 2 commits into from
Jan 22, 2024
Merged

[dotnet] Fix detecting if the interpreter is enabled. #19812

merged 2 commits into from
Jan 22, 2024

Conversation

rolfbjarne
Copy link
Member

@rolfbjarne rolfbjarne commented Jan 12, 2024 •
edited
Loading

The canonical property we use for the interpreter is MtouchInterpreter - and
the interpreter is enabled if MtouchInterpreter is set to any value (the
MtouchInterpreter value is used to select which assemblies to interpret, the
only way to completely disable the interpreter is to not set
MtouchInterpreter at all).

So fix a couple of cases of wrong comparison:

  • Don't use UseInterpreter - which is used to compute a specific value for
    MtouchInterpreter - because developers don't have to set UseInterpreter
    to enable the interpreter, they can set MtouchInterpreter directly.
  • Don't compare MtouchInterpreter with true: that only checks if the
    assembly "true" is interpreted (which it rarely is).

Fixes dotnet/runtime#96920.

@rolfbjarne
[dotnet] Fix detecting if the interpreter is enabled.
ea33e78 
The canonical property we use for the interpreter is `MtouchInterpreter` - and
the interpreter is enabled if `MtouchInterpreter` is set to any value (the
`MtouchInterpreter` value is used to select which assemblies to interpret, the
only way to completely disable the interpreter is to not set
`MtouchInterpreter` at all).

So fix a couple of cases of wrong comparison:

* Don't use `UseInterpreter` - which is used to compute a specific value for
  `MtouchInterpreter` - because developers don't have to set `UseInterpreter`
  to enable the interpreter, they can set `MtouchInterpreter` directly.
* Don't compare `MtouchInterpreter` with `true`: that only checks if the
  assembly "true" is interpreted (which it rarely is).
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13.0) passed.

Pipeline on Agent
Hash: [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent
Hash: [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)
  • iOS (no change detected)
  • tvOS (no change detected)
  • watchOS (no change detected)
  • macOS (no change detected)
NET (empty diffs)
  • iOS: (empty diff detected)
  • tvOS: (empty diff detected)
  • MacCatalyst: (empty diff detected)
  • macOS: (empty diff detected)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)
.NET (No breaking changes)
Legacy Xamarin (stable) vs .NET

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 993f1cccdf000e601a8d39f50ec9d432301f1c10 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: 993f1cccdf000e601a8d39f50ec9d432301f1c10 [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2
Copy link
Collaborator

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: simulator tests.

🎉 All 235 tests passed 🎉

Tests counts

✅ bcl: All 69 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 6 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 41 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 993f1cccdf000e601a8d39f50ec9d432301f1c10 [PR build]

@rolfbjarne rolfbjarne mentioned this pull request Jan 22, 2024
Closed
@rolfbjarne rolfbjarne merged commit b1fa068 into xamarin:main Jan 22, 2024
70 checks passed
@rolfbjarne rolfbjarne deleted the msbuild-interpreter-comparison branch January 22, 2024 11:43
@simonrozsival simonrozsival mentioned this pull request May 3, 2024
Closed
rolfbjarne added a commit to rolfbjarne/xamarin-macios that referenced this pull request May 6, 2024
@rolfbjarne
[net9.0] Fix boolean condition to determine whether dynamic code is s…
6edb63e 
…upported or not. Fixes #dotnet/runtime@101840.

Dynamic code is not supported if the interpreter is not enabled, and the
interpreter is not enabled if the MtouchInterpreter property is *empty*.

This regression was introduced in xamarin#19812.

Fixes dotnet/runtime#101840.
@rolfbjarne rolfbjarne mentioned this pull request May 6, 2024
Merged
rolfbjarne added a commit that referenced this pull request May 7, 2024
@rolfbjarne
[net9.0] Fix boolean condition to determine whether dynamic code is s…
f97948d 
…upported or not. Fixes #dotnet/runtime@101840. (#20563)

Dynamic code is not supported if the interpreter is not enabled, and the
interpreter is not enabled if the MtouchInterpreter property is *empty*.

This regression was introduced in #19812.

Fixes dotnet/runtime#101840.
rolfbjarne added a commit to rolfbjarne/xamarin-macios that referenced this pull request Jun 6, 2024
@rolfbjarne
Fix boolean condition to determine whether dynamic code is supported …
b1dd786 
…or not. Fixes #dotnet/runtime@101840. (xamarin#20563)

Dynamic code is not supported if the interpreter is not enabled, and the
interpreter is not enabled if the MtouchInterpreter property is *empty*.

This regression was introduced in xamarin#19812.

Fixes dotnet/runtime#101840.
@rolfbjarne rolfbjarne mentioned this pull request Jun 6, 2024
Merged
rolfbjarne added a commit that referenced this pull request Jun 7, 2024
@rolfbjarne
Fix boolean condition to determine whether dynamic code is supported …
a72bb30 
…or not. Fixes #dotnet/runtime@101840. (#20563) (#20696)

Dynamic code is not supported if the interpreter is not enabled, and the
interpreter is not enabled if the MtouchInterpreter property is *empty*.

This regression was introduced in #19812.

Fixes dotnet/runtime#101840.
rolfbjarne added a commit to rolfbjarne/xamarin-macios that referenced this pull request Jun 17, 2024
@rolfbjarne
[dotnet] Fix detecting if the interpreter is enabled. (xamarin#19812)
8c6b54b 
The canonical property we use for the interpreter is `MtouchInterpreter` - and
the interpreter is enabled if `MtouchInterpreter` is set to any value (the
`MtouchInterpreter` value is used to select which assemblies to interpret, the
only way to completely disable the interpreter is to not set
`MtouchInterpreter` at all).

So fix a couple of cases of wrong comparison:

* Don't use `UseInterpreter` - which is used to compute a specific value for
  `MtouchInterpreter` - because developers don't have to set `UseInterpreter`
  to enable the interpreter, they can set `MtouchInterpreter` directly.
* Don't compare `MtouchInterpreter` with `true`: that only checks if the
  assembly "true" is interpreted (which it rarely is).

Fixes dotnet/runtime#96920.
rolfbjarne added a commit to rolfbjarne/xamarin-macios that referenced this pull request Jun 17, 2024
@rolfbjarne
Fix boolean condition to determine whether dynamic code is supported …
f96b7b2 
…or not. Fixes #dotnet/runtime@101840. (xamarin#20563) (xamarin#20696)

Dynamic code is not supported if the interpreter is not enabled, and the
interpreter is not enabled if the MtouchInterpreter property is *empty*.

This regression was introduced in xamarin#19812.

Fixes dotnet/runtime#101840.
@rolfbjarne rolfbjarne mentioned this pull request Jun 17, 2024
Merged
rolfbjarne added a commit that referenced this pull request Jun 18, 2024
@rolfbjarne
[release/8.0.1xx-xcode15.1] [dotnet] Fix detecting if the interpreter…
6c1d0b0 
… is enabled. (#20732)

The canonical property we use for the interpreter is `MtouchInterpreter` - and
the interpreter is enabled if `MtouchInterpreter` is set to any value (the
`MtouchInterpreter` value is used to select which assemblies to interpret, the
only way to completely disable the interpreter is to not set
`MtouchInterpreter` at all).

So fix a couple of cases of wrong comparison:

* Don't use `UseInterpreter` - which is used to compute a specific value for
  `MtouchInterpreter` - because developers don't have to set `UseInterpreter`
  to enable the interpreter, they can set `MtouchInterpreter` directly.
* Don't compare `MtouchInterpreter` with `true`: that only checks if the
  assembly "true" is interpreted (which it rarely is).

Fixes dotnet/runtime#96920.

This is a backport of #19812 and #20696.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalexsoto dalexsoto dalexsoto approved these changes

@mandel-macaque mandel-macaque mandel-macaque approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

XmlCompiledTransform.Load throws a System.PlatformNotSupportedException on iOS with .NET 8
4 participants
@rolfbjarne @vs-mobiletools-engineering-service2 @dalexsoto @mandel-macaque