Fix boolean condition to determine whether dynamic code is supported or not. Fixes #dotnet/runtime@101840. (#20563) #20696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or not. Fixes #dotnet/runtime@101840. (xamarin#20563) Dynamic code is not supported if the interpreter is not enabled, and the interpreter is not enabled if the MtouchInterpreter property is *empty*. This regression was introduced in xamarin#19812. Fixes dotnet/runtime#101840.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
mandel-macaque
approved these changes
Jun 6, 2024
dalexsoto
approved these changes
Jun 6, 2024
haritha-mohan
approved these changes
Jun 7, 2024
📚 [PR Build] Artifacts 📚Packages generatedView packagesPipeline on Agent |
✅ API diff for current PR / commitLegacy Xamarin (No breaking changes)
NET (empty diffs)
✅ API diff vs stableLegacy Xamarin (No breaking changes).NET (No breaking changes)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
rolfbjarne
added a commit
to rolfbjarne/xamarin-macios
that referenced
this pull request
Jun 17, 2024
…or not. Fixes #dotnet/runtime@101840. (xamarin#20563) (xamarin#20696) Dynamic code is not supported if the interpreter is not enabled, and the interpreter is not enabled if the MtouchInterpreter property is *empty*. This regression was introduced in xamarin#19812. Fixes dotnet/runtime#101840.
rolfbjarne
added a commit
that referenced
this pull request
Jun 18, 2024
… is enabled. (#20732) The canonical property we use for the interpreter is `MtouchInterpreter` - and the interpreter is enabled if `MtouchInterpreter` is set to any value (the `MtouchInterpreter` value is used to select which assemblies to interpret, the only way to completely disable the interpreter is to not set `MtouchInterpreter` at all). So fix a couple of cases of wrong comparison: * Don't use `UseInterpreter` - which is used to compute a specific value for `MtouchInterpreter` - because developers don't have to set `UseInterpreter` to enable the interpreter, they can set `MtouchInterpreter` directly. * Don't compare `MtouchInterpreter` with `true`: that only checks if the assembly "true" is interpreted (which it rarely is). Fixes dotnet/runtime#96920. This is a backport of #19812 and #20696.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dynamic code is not supported if the interpreter is not enabled, and the
interpreter is not enabled if the MtouchInterpreter property is empty.
This regression was introduced in #19812.
Fixes dotnet/runtime#101840.