[msbuild] Use exact version of XVS' packages. #20043
Conversation
There are testing versions of the XVS' packages in some feeds with version 99.**, but we don't want to reference those by accident, so make sure we reference the exact version of the XVS NuGet packages. This has caused bugs multiple times in the past, the reference below is just the latest one. Ref: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1950696/?view=edit
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
A recent bump in the HotRestartVersion seems to be to a version of Hot Restart that doesn't need/provide the BouncyCastle.Crypto library. Unfortunately due to another issue, the bump didn't actually bring in the updated Hot Restart version (the required NuGet packages weren't published to a feed we subscribe to, so we silently [1] got a different version of the Hot Restart packages). This means our build didn't break in the actual bump, but only when the corresponding Hot Restart package versions were published to the designated feeds (i.e. yesterday). [1]: We got a warning, but no build error. xamarin#20043 fixes this problem.
#20044) A recent bump in the HotRestartVersion seems to be to a version of Hot Restart that doesn't need/provide the BouncyCastle.Crypto library. Unfortunately due to another issue, the bump didn't actually bring in the updated Hot Restart version (the required NuGet packages weren't published to a feed we subscribe to, so we silently [1] got a different version of the Hot Restart packages). This means our build didn't break in the actual bump, but only when the corresponding Hot Restart package versions were published to the designated feeds (i.e. yesterday). [1]: We got a warning, but no build error. #20043 fixes this problem.
📚 [PR Build] Artifacts 📚Packages generatedView packagesPipeline on Agent |
💻 [PR Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻✅ All tests on macOS X64 - Mac Sonoma (14) passed. Pipeline on Agent |
💻 [PR Build] Tests on macOS M1 - Mac Ventura (13) passed 💻✅ All tests on macOS M1 - Mac Ventura (13) passed. Pipeline on Agent |
💻 [PR Build] Tests on macOS M1 - Mac Monterey (12) passed 💻✅ All tests on macOS M1 - Mac Monterey (12) passed. Pipeline on Agent |
💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11) passed 💻✅ All tests on macOS M1 - Mac Big Sur (11) passed. Pipeline on Agent |
💻 [CI Build] Windows Integration Tests passed 💻✅ All Windows Integration Tests passed. Pipeline on Agent |
✅ API diff for current PR / commitLegacy Xamarin (No breaking changes)
NET (empty diffs)
✅ API diff vs stableLegacy Xamarin (No breaking changes).NET (No breaking changes)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
🚀 [CI Build] Test results 🚀Test results✅ All tests passed on VSTS: simulator tests. 🎉 All 170 tests passed 🎉 Tests counts✅ cecil: All 1 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
A recent bump in the HotRestartVersion seems to be to a version of Hot Restart that doesn't need/provide the BouncyCastle.Crypto library. Unfortunately due to another issue, the bump didn't actually bring in the updated Hot Restart version (the required NuGet packages weren't published to a feed we subscribe to, so we silently [1] got a different version of the Hot Restart packages). This means our build didn't break in the actual bump, but only when the corresponding Hot Restart package versions were published to the designated feeds (i.e. yesterday). [1]: We got a warning, but no build error. xamarin#20043 fixes this problem.
…stle.Crypto library anymore. (#20057) A recent bump in the HotRestartVersion seems to be to a version of Hot Restart that doesn't need/provide the BouncyCastle.Crypto library. Unfortunately due to another issue, the bump didn't actually bring in the updated Hot Restart version (the required NuGet packages weren't published to a feed we subscribe to, so we silently [1] got a different version of the Hot Restart packages). This means our build didn't break in the actual bump, but only when the corresponding Hot Restart package versions were published to the designated feeds (i.e. yesterday). [1]: We got a warning, but no build error. #20043 fixes this problem. Backport of #20044
There are testing versions of the XVS' packages in some feeds with version
99.**, but we don't want to reference those by accident, so make sure we
reference the exact version of the XVS NuGet packages.
This has caused bugs multiple times in the past, the reference below is just
the latest one.
Ref: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1950696/?view=edit