Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[msbuild] Don't try to bundle the BouncyCastle.Crypto library anymore. #20044

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

rolfbjarne
Copy link
Member

A recent bump in the HotRestartVersion seems to be to a version of Hot Restart
that doesn't need/provide the BouncyCastle.Crypto library.

Unfortunately due to another issue, the bump didn't actually bring in the
updated Hot Restart version (the required NuGet packages weren't published to
a feed we subscribe to, so we silently [1] got a different version of the Hot
Restart packages). This means our build didn't break in the actual bump, but
only when the corresponding Hot Restart package versions were published to the
designated feeds (i.e. yesterday).

[1]: We got a warning, but no build error. #20043 fixes this problem.

A recent bump in the HotRestartVersion seems to be to a version of Hot Restart
that doesn't need/provide the BouncyCastle.Crypto library.

Unfortunately due to another issue, the bump didn't actually bring in the
updated Hot Restart version (the required NuGet packages weren't published to
a feed we subscribe to, so we silently [1] got a different version of the Hot
Restart packages). This means our build didn't break in the actual bump, but
only when the corresponding Hot Restart package versions were published to the
designated feeds (i.e. yesterday).

[1]: We got a warning, but no build error. xamarin#20043 fixes this problem.
@vs-mobiletools-engineering-service2
Copy link
Collaborator

🔥 Failed to compare API and create generator diff 🔥

Error: 'make' failed for the hash 70530a8.

Pipeline on Agent
Hash: 4be76e3321040e9d3d8ec47e5c511628bd1bbb37 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent
Hash: [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [PR Build] Tests on macOS M1 - Mac Monterey (12) passed 💻

All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13) passed 💻

All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11) passed 💻

All tests on macOS M1 - Mac Big Sur (11) passed.

Pipeline on Agent
Hash: [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [PR Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻

All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [CI Build] Windows Integration Tests failed ❌

❌ Failed ❌

Pipeline on Agent
Hash: 4be76e3321040e9d3d8ec47e5c511628bd1bbb37 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build] Windows Integration Tests passed 💻

All Windows Integration Tests passed.

Pipeline on Agent
Hash: 4be76e3321040e9d3d8ec47e5c511628bd1bbb37 [PR build]

@rolfbjarne
Copy link
Member Author

Merging since the build is at least working.

@rolfbjarne rolfbjarne merged commit d64060c into xamarin:main Feb 6, 2024
69 of 79 checks passed
@rolfbjarne rolfbjarne deleted the fix-msbuild-breakage branch February 6, 2024 13:42
@rolfbjarne
Copy link
Member Author

/sudo backport release/9.0.1xx-preview1

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Backport Job to branch release/9.0.1xx-preview1 Created! The magic is happening here

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=9043843 for more details.

rolfbjarne pushed a commit that referenced this pull request Feb 8, 2024
…stle.Crypto library anymore. (#20057)

A recent bump in the HotRestartVersion seems to be to a version of Hot Restart
that doesn't need/provide the BouncyCastle.Crypto library.

Unfortunately due to another issue, the bump didn't actually bring in the
updated Hot Restart version (the required NuGet packages weren't published to
a feed we subscribe to, so we silently [1] got a different version of the Hot
Restart packages). This means our build didn't break in the actual bump, but
only when the corresponding Hot Restart package versions were published to the
designated feeds (i.e. yesterday).

[1]: We got a warning, but no build error. #20043 fixes this problem.


Backport of #20044
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants