openapi2jsonschema.py strips group to first subdomain

[james-callahan]

I'm trying to use FILENAME_FORMAT='{group}-{version}-{kind}'. I would have expected this to work with -schema-location './crd-schemas/{{ .Group }}-{{ .ResourceAPIVersion }}-{{ .ResourceKind }}.json'. However for some reason openapi2jsonschema.py splits the group on . and only uses the first component:

kubeconform/scripts/openapi2jsonschema.py

Line 154 in 3cb76bc

group=y["spec"]["group"].split(".")[0],

This means that it ends up creating monitoring-v1-prometheus.json, but kubeconform looks for monitoring.coreos.com-v1-prometheus.json

[yannh]

Apologies if I am slow to reply to requests with regards to this script - I do not understand it well enough and would need to have a number of unit tests to be sure changes do not break existing workflows. I actively rely on this script which is why I am conservative with changes. Thanks for your patience 🙇

[rgarcia89]

Same happens to me. When I run the crd-extractor.sh script the CRD admissionreports.kyverno.io.yaml is converted by the openapi2jsonschema to kyverno.io-v1alpha2.json. Since there are multiple kyverno CRDs only the last one remains in the json schema. However, if I go and run python3 $TMP_CRD_DIR/openapi2jsonschema.py $TMP_CRD_DIR/*.yaml manually everything works fine.

./crd-extractor.sh
JSON schema written to kyverno.io-v1alpha2.json
JSON schema written to monitoring.coreos.com-v1alpha1.json
JSON schema written to monitoring.coreos.com-v1.json
...

python3 $TMP_CRD_DIR/openapi2jsonschema.py $TMP_CRD_DIR/*.yaml
JSON schema written to admissionreport_v1alpha2.json
JSON schema written to alertmanagerconfig_v1alpha1.json
JSON schema written to alertmanager_v1.json
...

[rgarcia89]

nevermind... I just noticed that I somehow had

env |grep FILENAME_FORMAT
FILENAME_FORMAT={group}-{version}

configured...