Fix #130 in a backward-compatible way #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an alternative way to fix #130. Instead of changing the `group` variable content, this commit adds a new variable `fullgroup` that does not split the group components. With this, users can specify the filename format like: FILENAME_FORMAT='{fullgroup}-{version}-{kind}'
|
Yep why not! Thanks ❤️ |
yannh
pushed a commit
that referenced
this pull request
Jul 9, 2023
This is a follow-up to #219 to add a short description on how to use the `fullgroup` variable.
yannh
pushed a commit
to levenleven/kubeconform
that referenced
this pull request
Jul 9, 2023
This is an alternative way to fix yannh#130. Instead of changing the `group` variable content, this commit adds a new variable `fullgroup` that does not split the group components. With this, users can specify the filename format like: FILENAME_FORMAT='{fullgroup}-{version}-{kind}'
yannh
pushed a commit
to levenleven/kubeconform
that referenced
this pull request
Jul 9, 2023
This is a follow-up to yannh#219 to add a short description on how to use the `fullgroup` variable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative way to fix #130.
Instead of changing the
groupvariable content, this commit addsa new variable
fullgroupthat does not split the group components.With this, users can specify the filename format like: