-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix licenses #964
Fix licenses #964
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #964 +/- ##
=======================================
Coverage 94.39% 94.39%
=======================================
Files 93 93
Lines 21060 21060
=======================================
Hits 19880 19880
Misses 1180 1180
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
// Copyright 2022 Zeitgeist PM LLC. | ||
// Copyright 2022-2023 Forecasting Technologies LTD. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is Zeitgeist PM LLC.
removed here? I some other files such as src/parameters.rs it is kept, in others it's removed. I can't make out a pattern.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it because 2022
the change of entities happened? Is it sufficient to only name one in that case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it because
2022
the change of entities happened?
Yes. Forecasting Technologies took over in October 2022, and the asset_registry.rs
was created in November of the same year: https://github.com/zeitgeistpm/zeitgeist/commits/0e5af7f33a0445c72e72e0a1a1378c05157dd565/runtime/battery-station/src/xcm_config/asset_registry.rs.
Is it sufficient to only name one in that case?
Seem reasonable to me. Everyone working on this file was employed by Forecasting Technologies. Why would Zeitgeist PM retain a copyright? That being said, I'm making all of this up on the spot using only common sense. If you want to know for sure (including how copyright notices and licenses should be managed), you should ask a lawyer.
Fixing licenses according to their git changelog. Process was partially automated, partially manual. This needs to be merged before #963.