Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix licenses #964

Merged
merged 1 commit into from
Feb 6, 2023
Merged

Fix licenses #964

merged 1 commit into from
Feb 6, 2023

Conversation

maltekliemann
Copy link
Member

Fixing licenses according to their git changelog. Process was partially automated, partially manual. This needs to be merged before #963.

@codecov-commenter
Copy link

Codecov Report

Merging #964 (0e5af7f) into main (45edad6) will not change coverage.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main     #964   +/-   ##
=======================================
  Coverage   94.39%   94.39%           
=======================================
  Files          93       93           
  Lines       21060    21060           
=======================================
  Hits        19880    19880           
  Misses       1180     1180           
Flag Coverage Δ
tests 94.39% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
primitives/src/asset.rs 41.17% <ø> (ø)
primitives/src/constants.rs 0.00% <ø> (ø)
primitives/src/market.rs 71.42% <ø> (ø)
.../src/traits/zeitgeist_multi_reservable_currency.rs 53.65% <ø> (ø)
primitives/src/types.rs 3.12% <ø> (ø)
zrml/authorized/src/benchmarks.rs 100.00% <ø> (ø)
zrml/authorized/src/migrations.rs 0.00% <ø> (ø)
zrml/authorized/src/mock.rs 37.50% <ø> (ø)
zrml/authorized/src/mock_storage.rs 3.12% <ø> (ø)
zrml/authorized/src/tests.rs 100.00% <ø> (ø)
... and 54 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@maltekliemann maltekliemann self-assigned this Feb 3, 2023
@maltekliemann maltekliemann added the s:review-needed The pull request requires reviews label Feb 3, 2023
@maltekliemann maltekliemann added this to the v0.3.9 milestone Feb 3, 2023
// Copyright 2022 Zeitgeist PM LLC.
// Copyright 2022-2023 Forecasting Technologies LTD.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is Zeitgeist PM LLC. removed here? I some other files such as src/parameters.rs it is kept, in others it's removed. I can't make out a pattern.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it because 2022 the change of entities happened? Is it sufficient to only name one in that case?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it because 2022 the change of entities happened?

Yes. Forecasting Technologies took over in October 2022, and the asset_registry.rs was created in November of the same year: https://github.com/zeitgeistpm/zeitgeist/commits/0e5af7f33a0445c72e72e0a1a1378c05157dd565/runtime/battery-station/src/xcm_config/asset_registry.rs.

Is it sufficient to only name one in that case?

Seem reasonable to me. Everyone working on this file was employed by Forecasting Technologies. Why would Zeitgeist PM retain a copyright? That being said, I'm making all of this up on the spot using only common sense. If you want to know for sure (including how copyright notices and licenses should be managed), you should ask a lawyer.

@sea212 sea212 requested a review from Chralt98 February 6, 2023 13:10
node/src/rpc.rs Show resolved Hide resolved
@maltekliemann maltekliemann added s:accepted This pull request is ready for merge and removed s:review-needed The pull request requires reviews labels Feb 6, 2023
@maltekliemann maltekliemann merged commit b32774b into main Feb 6, 2023
@maltekliemann maltekliemann deleted the mkl-fix-license-files branch February 6, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s:accepted This pull request is ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants