Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix licenses #964
Fix licenses #964
Changes from all commits
0e5af7f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is
Zeitgeist PM LLC.
removed here? I some other files such as src/parameters.rs it is kept, in others it's removed. I can't make out a pattern.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it because
2022
the change of entities happened? Is it sufficient to only name one in that case?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. Forecasting Technologies took over in October 2022, and the
asset_registry.rs
was created in November of the same year: https://github.com/zeitgeistpm/zeitgeist/commits/0e5af7f33a0445c72e72e0a1a1378c05157dd565/runtime/battery-station/src/xcm_config/asset_registry.rs.Seem reasonable to me. Everyone working on this file was employed by Forecasting Technologies. Why would Zeitgeist PM retain a copyright? That being said, I'm making all of this up on the spot using only common sense. If you want to know for sure (including how copyright notices and licenses should be managed), you should ask a lawyer.