RuntimeException Layer and request path have gone out of sync for capitalised piped route #168

jakeBarwell · 2018-04-14T21:21:11Z

Getting a RuntimeException
"Layer and request path have gone out of sync"
From zendframework/zend-stratigility/src/Next.php line 271

Code to reproduce the issue

Add piped route like this for example
$app->pipe('/myadmin', \App\Middleware\Auth\AdminAuth::class);

Then via browser go to /MYADMIN
(Note the capital letters)

Expected results

Either 404 or it matches that route

Actual results

RuntimeException
"Layer and request path have gone out of sync"

jakeBarwell · 2018-04-15T07:51:58Z

Sorry that was on version 2.1.2 just upgraded to 2.2.1 and similar behaviour

Exception\PathOutOfSyncException thrown from src/Middleware/PathMiddlewareDecorator.php line 128

Looking at master branch, I do not think this will still be an issue.

In zendframework#168, we received a report indicating that path matching within `PathMiddlewareDecorator` fails if the path is the same, but using a different case. Interestingly, we _match_ it correctly; the problem is when _preparing the truncated path_ to pass on to the decorated middleware, as it cannot identify the matched segment correctly. This patch modifies the logic in `getTruncatedPath()` to do a case-insensitive comparison of the segment and the path in the initial condition.

weierophinney · 2018-04-16T18:23:28Z

Fixed with #169 and new 2.2.2 release; I'm preparing a patch for the 3.0 series as well.

In zendframework#168, we received a report indicating that path matching within `PathMiddlewareDecorator` fails if the path is the same, but using a different case. This patch forward-ports the test from patch 44f8885 to the 3.0 series; the 3.0 series was already working correctly.

weierophinney · 2018-04-16T18:31:32Z

The patch prepared for master, #170, only includes the unit test, as the behavior was already correct in that branch.

weierophinney mentioned this issue Apr 16, 2018

Fixes path truncation in PathMiddlewareDecorator to be case insensitive #169

Merged

weierophinney closed this as completed Apr 16, 2018

weierophinney mentioned this issue Apr 16, 2018

Forward port test from v2 series regarding path truncation #170

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

RuntimeException Layer and request path have gone out of sync for capitalised piped route #168

RuntimeException Layer and request path have gone out of sync for capitalised piped route #168

jakeBarwell commented Apr 14, 2018 •

edited

Loading

jakeBarwell commented Apr 15, 2018 •

edited

Loading

weierophinney commented Apr 16, 2018

weierophinney commented Apr 16, 2018

RuntimeException Layer and request path have gone out of sync for capitalised piped route #168

RuntimeException Layer and request path have gone out of sync for capitalised piped route #168

Comments

jakeBarwell commented Apr 14, 2018 • edited Loading

Code to reproduce the issue

Expected results

Actual results

jakeBarwell commented Apr 15, 2018 • edited Loading

weierophinney commented Apr 16, 2018

weierophinney commented Apr 16, 2018

jakeBarwell commented Apr 14, 2018 •

edited

Loading

jakeBarwell commented Apr 15, 2018 •

edited

Loading