This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Fixes path truncation in PathMiddlewareDecorator to be case insensitive #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In zendframework#168, we received a report indicating that path matching within `PathMiddlewareDecorator` fails if the path is the same, but using a different case. Interestingly, we _match_ it correctly; the problem is when _preparing the truncated path_ to pass on to the decorated middleware, as it cannot identify the matched segment correctly. This patch modifies the logic in `getTruncatedPath()` to do a case-insensitive comparison of the segment and the path in the initial condition.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #168, we received a report indicating that path matching within
PathMiddlewareDecoratorfails if the path is the same, but using a different case.Interestingly, we match it correctly; the problem is when preparing the truncated path to pass on to the decorated middleware, as it cannot identify the matched segment correctly.
This patch modifies the logic in
getTruncatedPath()to do a case-insensitive comparison of the segment and the path in the initial condition.This problem is likely relevant in current master as well, and will be ported to that branch on completion.
Fixes #168