This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Ensure Next processes the next delegate correctly when an error is present #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…esent Discovered when updating tests for Expressive to work with Stratigility 1.3. Essentially, when nesting pipelines, if an inner middleware pipeline is exhausted and a non-null `$err` is present, if the next delegate was a `Next` instance, it was improperly being called as an http-interop `DelegateInterface`, losing the error argument. As such, if any parent delegate contained error middleware, it would never be invoked.
…response prototype is present I suspected at one point that callable middleware was being decorated as interop middleware, which would cause problems with manipulated responses. It was not, but this test proves it.
weierophinney
added a commit
that referenced
this pull request
Nov 11, 2016
weierophinney
added a commit
that referenced
this pull request
Nov 11, 2016
weierophinney
added a commit
that referenced
this pull request
Nov 11, 2016
Forward port #85 Conflicts: CHANGELOG.md src/Next.php test/MiddlewarePipeTest.php test/NextTest.php
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered when updating tests for Expressive to work with Stratigility 1.3. Essentially, when nesting pipelines, if an inner middleware pipeline is exhausted and a non-null
$erris present, if the next delegate was aNextinstance, it was improperly being called as an http-interopDelegateInterface, losing the error argument. As such, if any parent delegate contained error middleware, that middleware would never be invoked.This may be related to #84.