Skip to content
This repository has been archived by the owner on Jan 29, 2020. It is now read-only.

Ensure Next processes the next delegate correctly when an error is present #85

Merged
merged 2 commits into from
Nov 11, 2016
Merged

Ensure Next processes the next delegate correctly when an error is present #85

merged 2 commits into from
Nov 11, 2016

Commits on Nov 11, 2016

  1. Ensure Next processes the next delegate correctly when an error is pr… 

    …esent

Discovered when updating tests for Expressive to work with Stratigility
1.3. Essentially, when nesting pipelines, if an inner middleware
pipeline is exhausted and a non-null `$err` is present, if the next
delegate was a `Next` instance, it was improperly being called as an
http-interop `DelegateInterface`, losing the error argument. As such, if
any parent delegate contained error middleware, it would never be
invoked.
    @weierophinney
    weierophinney committed Nov 11, 2016
    Configuration menu
    Copy the full SHA
    f3c90f6 View commit details
    Browse the repository at this point in the history

  2. Added test to ensure that callable middleware is not decorated if no … 

    …response prototype is present

I suspected at one point that callable middleware was being decorated
as interop middleware, which would cause problems with manipulated
responses. It was not, but this test proves it.
    @weierophinney
    weierophinney committed Nov 11, 2016
    Configuration menu
    Copy the full SHA
    3360255 View commit details
    Browse the repository at this point in the history