-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GMNS v0.85 #17
Merged
Merged
GMNS v0.85 #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New road_link file with geometry information
New offroad_link file with geometry information
Optional file that may be used when shapepoints are NOT contained directily in road_link or offroad_link files.
Either the shapepoints are contained in this file (geometry field), or in the Geometry file, referenced by a foreign key (geometry_id)
Either the shapepoints are contained in this file (geometry field), or in the Geometry file, referenced by a foreign key (geometry_id)
typo fix
(does not reflect potential change/removal of link_geometry table)
combining road_link and offroad_link; adding parent-child concept; adding segment_lane.
typos, and added a very short readme
Changed Other Fields to a statement that ad hoc fields may be added
Changed other_fields to a note about ad hoc fields. Capacity as vehicles / lane / hour (issue 16)
Ad hoc fields, and units
Ad hoc fields, Response to issues 8, 9
(i.e., remove their appearance as a "table entry")
for specification folder
per Scott's suggestion
Road_Link to Link
change to lower case
This was
linked to
issues
May 9, 2020
Closed
Closed
This was
unlinked from
issues
May 20, 2020
Closed
This was
linked to
issues
May 20, 2020
Lazy approval received; merging (see issue #18 for PMC vote). |
dtemkin-volpe
added a commit
that referenced
this pull request
Jul 19, 2024
Update Spec Documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request proposes changes to the specification based on several issues raised by @e-lo and @xzhou99, and discussed at PMC meetings in March and May, 2020.
Major changes
Combining link_geometry, road_link, and offroad_link tables (#3, #7)
We propose combining these tables into a single link table.
road_link_id
field becomeslink_id
link_geometry_id
is removed from the link table. Geometry information can now be stored in two different ways:geometry
fieldgeometry_id
field. Unlike the link_geometry table, this geometry table does not contain fields for additional characteristics – these are all stored on the link table.offroad_link
table is removeddirected
field on the link table indicates whether the link is directed or undirecteddir_flag
field can now have value 0 (representing an undirected link or a link without geometry information) in addition to 1 (travel with shapepoint direction) and -1 (travel against shapepoints)Inheritance: parent fields and segment_lane table (#7, #14)
It can be useful to define a parent from which a link or node can inherit characteristics – for example, a crosswalk entrance node on a pedestrian network is the child of the intersection node at the road network, so they can be signalized together. Or, to conserve disk space, one may wish to provide characteristics for a two-way road on only one of the directed links that makes up that road.
Therefore,
parent_link
andparent_node
fields are added to the link and node tables, respectively. If this field is filled, then blank fields on the child will inherit values from the parent.Similarly, when a link is divided into segments or lanes, these also can inherit values from the link. The segment_lane table allows for lanes to change characteristics along a segment (as well as adding or dropping lanes). This table contains a
parent_lane
field, to key a changed lane to its usual characteristics along the rest of the link.Splitting time-of-day tables (#14, #5)
Rather than allow for link, lane, and segment time of day changes to occur on a single Link_TOD table (meaning that multiple foreign keys have to be checked), we propose defining separate link_tod, link_lane_tod, segment_tod, and segment_lane_tod tables. Similar to how geometries are handled, there is now also an optional time_set_definitions file to allow for time-of-day sets to be defined on a separate table instead of the
XXXXXXXX_HHMM_HHMM
format.Minor changes
Several cleanup edits and clarifications to documentation were also made, including:
loc_type
(Use OSM standards for location type #10)capacity
field is per-lane (capacity - should we make it per lane? #16)zone_id
, plus creation of a basic zone table (Be consistent between zone and zone_id #11)x_coord
andy_coord
fields for visualization over linear reference on the location table (x_coord, y_coord in locations provides duplicative (potentially conflicting) information #9)Example network
One small example has been drafted to show these changes as implemented: Cambridge_v085. The other examples, along with the conversion and validation tools, have not yet been updated to reflect these changes, but will be upon approval of these changes.