-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GMNS v0.90 #40
Merged
Merged
GMNS v0.90 #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated signal ER diagram
Updated signal files for Broadway / Ames example
(not yet including recent updates to movements table)
(for the camb_v085 example, commenting out code for the geometry table)
and removing "old" warnings
To be replaced with updated SignalER in this branch
New signal ER file
reordering
add a primary key to `signal_phase_mvmt` (#28)
added comment for [y_coord], changed [zone_id] type from TEXT to Zone_ID, expanded comment for [ctrl_type], added "node data dictionary"
expanded examples of a zone, changed [zone_name] to [name]
added unit of feet to [row_width]
This was
linked to
issues
Aug 17, 2020
Closed
Closed
Closed
This was
unlinked from
issues
Aug 17, 2020
Allow all traffic signal objects to be associated with a timing_plan, so that they may vary by time of day.
issue #42
Co-Authored-By: ssmith55 <[email protected]>
typo
Co-Authored-By: ssmith55 <[email protected]>
Clarify that link_id is not necessarily an integer
fixing links
list primary key first
typo
This was referenced Sep 1, 2020
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request proposes changes to the specification based on comments received on the structure of the signal tables, several outstanding issues, and ongoing refinements.
Major changes
Restructuring of Signal tables
node_id
fields withcontroller_id
and added a controller_id table. (Signal phase concurrency (ring diagram): variability #26)signal_phase_mvmt_id
andsignal_phase_id
.position
andsignal_phase_num
. (Signal phase concurrency (ring diagram): completeness #25)time_day
field to signal_timing_plan table.phase_num
tosignal_phase_num
signal_phase_id
to signal_timing_phase table.Inheritance: Made fields consistent between parent and child relationships (#19, #33)
The inheritance relationships between tables were more clearly defined. See this figure for more detail. Changes to implement this include:
toll
field to link table.grade
,lanes
,toll
,jurisdiction
, androw_width
.table_name
_id
segment_lane_id
segment_lane_tod_id
.lane_tod_id
and referenceslane_id
instead oflink_id
.Clarified role of
notes
fields (#37)The
notes
is an optional ad hoc field that is used in many of our examples, but it should not be included in the base specification.New Time of Day Examples
Two new examples (I-93 and CT Ave have been added that demonstrate the use of different TOD tables.
Minor changes
ib_lane
intostart_ib_lane
andend_ib_lane
(same for outbound). (Movement ib_lane #20)link_id
field from the segment_lane table as it was redundant.Several cleanup edits and clarifications to documentation were also made, including:
Examples and conversions
Examples and conversion tools have been updated to reflect updates to the specification. Additionally, one new conversion script was added, from GMNS to Network Wrangler.