Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GMNS v0.90 #40

Merged
merged 104 commits into from
Sep 1, 2020
Merged

GMNS v0.90 #40

merged 104 commits into from
Sep 1, 2020

Conversation

ianberg-volpe
Copy link
Collaborator

@ianberg-volpe ianberg-volpe commented Aug 14, 2020

This pull request proposes changes to the specification based on comments received on the structure of the signal tables, several outstanding issues, and ongoing refinements.

Major changes

Restructuring of Signal tables

  • Replaced node_id fields with controller_id and added a controller_id table. (Signal phase concurrency (ring diagram): variability #26)
  • Reformatted old signal_phase table into new signal_phase_mvmt table:
    • Added signal_phase_mvmt_id and signal_phase_id.
  • Reformatted old signal_phase_concurrency table into new signal_phase table:
  • Smaller changes:
    • Added time_day field to signal_timing_plan table.
    • Renamed phase_num to signal_phase_num
    • Added signal_phase_id to signal_timing_phase table.

Inheritance: Made fields consistent between parent and child relationships (#19, #33)

The inheritance relationships between tables were more clearly defined. See this figure for more detail. Changes to implement this include:

  • Adding a toll field to link table.
  • Adding the following fields to the segment table: grade, lanes, toll, jurisdiction, and row_width.
  • Cleaning up primary keys: they are now all in the format table_name_id
    • Renamed link_lane_tod table to lane_tod.
    • The segment_lane primary key is now segment_lane_id
    • Segment_lane_tod primary key is now segment_lane_tod_id.
    • The lane_tod primary key is now lane_tod_id and references lane_id instead of link_id.

Clarified role of notes fields (#37)

The notes is an optional ad hoc field that is used in many of our examples, but it should not be included in the base specification.

New Time of Day Examples

Two new examples (I-93 and CT Ave have been added that demonstrate the use of different TOD tables.

Minor changes

Examples and conversions

Examples and conversion tools have been updated to reflect updates to the specification. Additionally, one new conversion script was added, from GMNS to Network Wrangler.

ianberg-volpe and others added 30 commits May 28, 2020 16:09
Updated signal ER diagram
Updated signal files for Broadway / Ames example
(not yet including recent updates to movements table)
(for the camb_v085 example, commenting out code for the geometry table)
and removing "old" warnings
To be replaced with updated SignalER in this branch
New signal ER file
reordering
add a primary key to `signal_phase_mvmt` (#28)
added comment for [y_coord],
changed [zone_id] type from TEXT to Zone_ID,
expanded comment for [ctrl_type],
added "node data dictionary"
expanded examples of a zone,
changed [zone_name] to [name]
added unit of feet to [row_width]
ssmith55 and others added 6 commits August 17, 2020 16:14
Allow all traffic signal objects to be associated with a timing_plan, so that they may vary by time of day.
Clarify that link_id is not necessarily an integer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants