Fix incorrect weighting used for permafrost pool adjustment #720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They should only run in the main repo. Solution from https://github.com/orgs/community/discussions/26684
Don't run scheduled jobs on forks
switch to the main branch
This reverts commit 021544e.
Differences in Hector outputsHello, this is The current pull request's outputs do not differ from 3.0.0 (9aebf67). |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #720 +/- ##
=======================================
Coverage 79.72% 79.72%
=======================================
Files 61 61
Lines 5978 5978
=======================================
Hits 4766 4766
Misses 1212 1212 ☔ View full report in Codecov by Sentry. |
Differences in Hector outputsHello, this is The current pull request's outputs do not differ from 3.0.0 (9aebf67). |
kdorheim
approved these changes
Dec 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
simpleNbox::stashCvaluesfunction was using incorrect biome weights when adjusting the permafrost pools. This resulted in extremely bad behavior when using more than a single biome.This initial PR is a straight bug fix, and should not change
mainbehavior at all (because permafrost remains disabled). I'll open a second PR to evaluate the effects of turning on permafrost by default in v3.Part of #675