Hector V3.2.0 #733
Merged
Hector V3.2.0 #733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kdorheim
commented
Feb 23, 2024
kdorheim
commented
- Correct aerosol forcing coefficients based on Zelinka et al. (2023)
- Enable permafrost module and recalibrate model's default parameterization
* QA/QC of permafrost performance * Incorrect weighting was being used for permafrost pool adjustment * Revert "QA/QC of permafrost performance" This reverts commit 021544e. * Update simpleNbox-runtime.cpp Co-authored-by: Kalyn R. Dorheim <[email protected]>
* Enable permafrost and clarify comments in INI files * Update test_hector.sh * Fix mistakes in ssp534-over INI * Update input parameters table and comparison data * Adjust thawed permafrost RH when matching NBP constraint * Add missing reset/rename lines; change new_thaw to derived * Copy pf_s when renaming biome * get_biome_inits needs to return thawed_permafrost pool * Remove unused variable * Clean up commenting * Rename new_thaw to f_new_thaw for clarity * Do not route CH4 to atmosphere, CH4 from thawed permafrost was being routed to both the CH4 component AND the simpleNbox atmosphere (effectively double-counting it as both CO2 and CH4) * Decompose labile, not static, fraction of thawed permafrost * Disable refreeze from soil * Update hector_comp.csv * Add permafrost to saved comparison data #722 (comment)
* Updates the aerosol factors from the IPCC AR6 parameters to adjusted values * Update old new comparison data * Fix typo
* Update params per #728 * Update the old new test (hector_comp.csv) as the new parameter values cause major behavior changes * Change the Q10-related test so that it tests the EOC temperature change when Q10 increases
* Update the version number * Remove the line width ggplot warning
|
Each commit here represents a work that has undergone peer-reviewed PR. |
bpbond
approved these changes
Feb 23, 2024
Differences in Hector outputsHello, this is The current pull request's outputs do not differ from 3.1.1 (d931a00). |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #733 +/- ##
==========================================
+ Coverage 79.72% 80.15% +0.43%
==========================================
Files 61 61
Lines 5978 5992 +14
==========================================
+ Hits 4766 4803 +37
+ Misses 1212 1189 -23 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.