CLI cleanups #550
Draft
CLI cleanups #550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reduce AbstractCLI to the bare minimum of providing authentication, help and testing env support. Move logic for batch processing in a new AbstractBatchProcessingCLI subclass. Use CommandLine.getParsedOptionValue() wherever possible. Move CommandGroup, SUCCESS, FAILURE in CLI interface.
Supplying an unknown option already produces an error when parsing arguments.
arteymix
force-pushed
the
development
branch
2 times, most recently
from
79530fc
to
d612215
Compare
arteymix
commented
Jan 31, 2023
|
|
||
| if ( arrayDesign == null ) { | ||
| log.error( String.format( "No ArrayDesign found with name %s.", name ) ); | ||
| } |
There was a problem hiding this comment.
This log does not belong here.
|
@ppavlidis you mentioned the need for a tabular output, this can fit in here with the new |
Ok I will probably look at that this week |
arteymix
force-pushed
the
development
branch
2 times, most recently
from
84692c7
to
e0ec3da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
buildOptionsandprocessOptionsinAbstractCLIsubclasses more than onceA few more things to look into:
@Autowiredto inject beans in CLI tools & removegetBean()