Eliminate offset/limit parameters and improve the code for retrieving… #859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… analysis VOs Remove unnecessary offset/limit parameters of getDatasetDifferentialExpressionAnalyses() (fix #841). Add a parameter to include analyses of subsets. Tidy up the DAO: - don't retrieve FVs for subsets if includeAnalysesOfSubsets is false - initialize proxies of both experiments and subsets Include analyses of subsets in the output of the endpoint. Add two new service methods to retrieve analysis VOs: one by a collection of BioAssaySet and another one for a single BioAssaySet. Use the latter for the REST API. Rename sourceExperiment to sourceExperimentId and retain the older name marked as deprecated (fix #844).
arteymix
commented
Sep 20, 2023
| public Map<ExpressionExperimentDetailsValueObject, List<DifferentialExpressionAnalysisValueObject>> getAnalysesByExperiment( | ||
| Collection<Long> ids, int offset, int limit ) { | ||
| public Map<ExpressionExperimentDetailsValueObject, List<DifferentialExpressionAnalysisValueObject>> getAnalysesByExperiments( | ||
| Collection<? extends BioAssaySet> experiments, boolean includeAnalysesOfSubsets ) { |
There was a problem hiding this comment.
I don't think we need that parameter. Also, it should default to true, not false.
This was referenced Sep 20, 2023
arteymix
force-pushed
the
development
branch
2 times, most recently
from
84692c7
to
e0ec3da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… analysis VOs
Remove unnecessary offset/limit parameters of getDatasetDifferentialExpressionAnalyses() (fix #841).
Add a parameter to include analyses of subsets.
Tidy up the DAO:
Include analyses of subsets in the output of the endpoint.
Add two new service methods to retrieve analysis VOs: one by a collection of BioAssaySet and another one for a single BioAssaySet. Use the latter for the REST API.
Rename sourceExperiment to sourceExperimentId and retain the older name marked as deprecated (fix #844).