Improve cacheability of filters #871
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arteymix
commented
Sep 25, 2023
| if ( filters != null ) { | ||
| Iterator<Iterable<Filter>> it = filters.iterator(); | ||
| if ( it.hasNext() ) { | ||
| Set<Long> ids = new HashSet<>( doLoadIdsWithCache( Filters.by( IterableUtils.toList( it.next() ) ), null, true ) ); |
There was a problem hiding this comment.
It might not be worth to do this for every single filter.
Maybe having a list of properties that are expensive to filter by would be interesting.
arteymix
commented
Sep 25, 2023
| * @author tesarst | ||
| * @author poirigui | ||
| */ | ||
| @Value | ||
| @EqualsAndHashCode(of = { "objectAlias", "operator", "requiredValue" }) | ||
| public class Filter implements PropertyMapping { | ||
| @EqualsAndHashCode(of = { "objectAlias", "propertyName", "operator", "requiredValue" }) |
There was a problem hiding this comment.
This should be included immediatly in the dev branch and next patch release.
arteymix
commented
Sep 25, 2023
| * | ||
| * <p> | ||
| * Clauses and sub-clauses are always sorted by objectAlias, propertyName, operator and requiredValue. A clause is | ||
| * sorted by its first element, if any. |
There was a problem hiding this comment.
This is not correct, a clause is sorted lexicographically and a sub-clause as mentioned.
arteymix
commented
Sep 25, 2023
| @@ -89,7 +89,7 @@ public CacheManager cacheManager() { | |||
| @Test | |||
| public void testFindTerm() throws OntologySearchException { | |||
| Collection<OntologyTerm> matches = gos.findTerm( "toxin" ); | |||
| assertEquals( 4, matches.size() ); | |||
| assertEquals( 7, matches.size() ); | |||
There was a problem hiding this comment.
This shouldn't be here...
arteymix
commented
Sep 25, 2023
| // assertThat( filters.iterator().next().get( 1 ) ) | ||
| // .hasFieldOrPropertyWithValue( "propertyName", "c" ) | ||
| // .hasFieldOrPropertyWithValue( "operator", Filter.Operator.eq ) | ||
| // .hasFieldOrPropertyWithValue( "requiredValue", "d" ); |
There was a problem hiding this comment.
Uncomment and fix this test.
arteymix
commented
Sep 25, 2023
| // assertThat( filters.iterator().next().get( 1 ) ) | ||
| // .hasFieldOrPropertyWithValue( "propertyName", "c" ) | ||
| // .hasFieldOrPropertyWithValue( "operator", Filter.Operator.eq ) | ||
| // .hasFieldOrPropertyWithValue( "requiredValue", "d" ); |
There was a problem hiding this comment.
Uncomment and fix this test.
arteymix
commented
Sep 25, 2023
| // assertThat( of.get( 1 ) ) | ||
| // .hasFieldOrPropertyWithValue( "propertyName", "g" ) | ||
| // .hasFieldOrPropertyWithValue( "operator", Filter.Operator.eq ) | ||
| // .hasFieldOrPropertyWithValue( "requiredValue", "h" ); |
There was a problem hiding this comment.
Uncomment and fix this test.
arteymix
commented
Sep 25, 2023
| // assertThat( of.get( 1 ) ) | ||
| // .hasFieldOrPropertyWithValue( "propertyName", "e" ) | ||
| // .hasFieldOrPropertyWithValue( "operator", Filter.Operator.eq ) | ||
| // .hasFieldOrPropertyWithValue( "requiredValue", "f" ); |
There was a problem hiding this comment.
Uncomment and fix this test.
arteymix
force-pushed
the
feature-cache-optimization-for-filters
branch
from
9c76424
to
068b152
Compare
arteymix
force-pushed
the
development
branch
2 times, most recently
from
84692c7
to
e0ec3da
Compare
Sort clauses and sub-clauses so that equivalent queries have identical filters. Implement padding to the next power-of-two by repeating the last element of a collection.
arteymix
force-pushed
the
feature-cache-optimization-for-filters
branch
from
068b152
to
0b3ce18
Compare
|
This has to be rebased and tested again. I'll try to squeeze it in tomorrow's release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sort clauses and sub-clauses so that equivalent queries have identical filters.
Implement padding to the next power-of-two by repeating the last element of a collection.
Break-up filters so we can cache expensive clauses and run simpler queries against the database.
Fix #869 and #870
TODO